-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing Galadriel Server Management Handlers API #150
Merged
maxlambrecht
merged 25 commits into
HewlettPackard:main
from
Victorblsilveira:victor/admin-handlers
May 16, 2023
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
bfdfcc4
feat: Implementing Admin Handlers
Victorblsilveira cbdaf26
feat: Adding unit testes helpers and implemenenting get relationships…
Victorblsilveira c55c71b
Merge branch 'main' into victor/admin-handlers
Victorblsilveira 664cb58
feat: Creating unit tests for relationshio request creation and impro…
Victorblsilveira d02e836
Merge remote-tracking branch 'origin/main' into victor/admin-handlers
Victorblsilveira a55e8fa
fix: Unmashaling assertion
Victorblsilveira a7edd5d
fix: Removin code duplication
Victorblsilveira c621801
fix: Organization
Victorblsilveira 4b49fcc
feat: Adding more unit tests
Victorblsilveira 5f3dcbd
feat: Changin return code for relationship request creation
Victorblsilveira 9bc7b3a
feat: Finishing unit tests
Victorblsilveira 46ca412
Update pkg/server/endpoints/management.go
Victorblsilveira 02de6e6
Update pkg/server/endpoints/management.go
Victorblsilveira 990cd61
Merge remote-tracking branch 'origin/main' into victor/admin-handlers
Victorblsilveira 85ce235
fix: Function names
Victorblsilveira 63306ec
fix: Centralizing common stuff
Victorblsilveira 2b5d958
fix: Removing const_test file and unit test changes
Victorblsilveira 38449f0
fix: Misstypes and const places
Victorblsilveira 21b679b
fix: Refactoring trust domain lookup functions
Victorblsilveira d9b7d39
Merge branch 'HewlettPackard:main' into victor/admin-handlers
Victorblsilveira 7eafbe5
fix: Unit tests failing
Victorblsilveira f085b5d
Merge remote-tracking branch 'origin/main' into victor/admin-handlers
Victorblsilveira b60cec3
fix: Removing unused values
Victorblsilveira 4da954f
fix: Unit test failing
Victorblsilveira b92ffcb
fix: Unit test checking
Victorblsilveira File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why add this parameter that is not used?
Name suggestions for this function:
NoContentResponse
orEmptyResponse
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Misstype