Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #84 Wrong MCC+MNC encoding #85

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Fix #84 Wrong MCC+MNC encoding #85

merged 2 commits into from
Feb 28, 2024

Conversation

linouxis9
Copy link
Member

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have read the CONTRIBUTING document.
  • Each of my commits messages include Signed-off-by: Author Name <[email protected]> to accept the DCO.

@linouxis9
Copy link
Member Author

Hi @rjaksa,

Your bug should be fixed by this PR. Can you try PacketRusher again with this fix / using branch fixmnc.

Thanks a lot,
Valentin

@rjaksa
Copy link

rjaksa commented Feb 28, 2024

The code change works for the gNB. But there is an informative printf regarding the PLMNs Identities supported by AMF that shows the MNC incorrectly. It lists the 3-digit MNC with the digits in encoded order, instead of the "human readable" format. E.g. MNC 123 is printed as "231".

E.g. for MCC=987, MNC=123, the printf looks like:

INFO[0000] [GNB][AMF] PLMNs Identities Supported by AMF -- mcc: 987 mnc:231

@linouxis9
Copy link
Member Author

Thank you @rjaksa, it's fixed!

@linouxis9 linouxis9 merged commit 97f9f0c into main Feb 28, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants