Use gnbId from config.yml as first gNB's ID, Fix #48 #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linouxis9
force-pushed
the
fix48
branch
2 times, most recently
from
09d97e1 to
17c59fb
Compare
Closed
yoursunny
reviewed
Dec 24, 2023
internal/common/tools/tools.go
Outdated
|
|
||
| gnbId := base + strconv.Itoa(i) | ||
| gnbId = fmt.Sprintf("%06d", base) |
There was a problem hiding this comment.
I know the codebase currently only supports 24-bit gNB ID. This should be generalized in the future, to allow configuration length of gNB ID vs Cell ID.
https://www.techplayon.com/5g-nr-cell-global-identity-planning/
There was a problem hiding this comment.
To be implemented in #51
Signed-off-by: Valentin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Fix [BUG] wrong gNB ID #48
Signed-off-by: Author Name <[email protected]>to accept the DCO.