Controller manager integration #6
Conversation
Signed-off-by: Alexandre Alvino <[email protected]>
Signed-off-by: Alexandre Alvino <[email protected]>
Signed-off-by: Alexandre Alvino <[email protected]>
Signed-off-by: Alexandre Alvino <[email protected]>
Signed-off-by: Alexandre Alvino <[email protected]>
Signed-off-by: Alexandre Alvino <[email protected]>
Signed-off-by: Alexandre Alvino <[email protected]>
Signed-off-by: Alexandre Alvino <[email protected]>
|
Hi @alexandrealvino. Thanks for your PR. I'm waiting for a HewlettPackard member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
alexandrealvino
requested review from
maxlambrecht,
jufantozzi,
mchurichi,
mgbcaio,
n-th and
a team
usecases/workload-to-ingress-upstream-spire/server-cluster/workloads/deploy-workloads.sh
Outdated
Show resolved
Hide resolved
Signed-off-by: Alexandre Alvino <[email protected]>
…il into controller-manager
POC/spire/spire-server-test.yaml
Outdated
| @@ -0,0 +1,299 @@ | |||
| apiVersion: v1 | |||
There was a problem hiding this comment.
No, only for me in my local env haha. I will remove this leftover, thanks!
Signed-off-by: Alexandre Alvino <[email protected]>
| metadata: | ||
| name: ingress | ||
| spec: | ||
| spiffeIDTemplate: spiffe://example.org/ingress/{{ .PodMeta.Name }} |
There was a problem hiding this comment.
Why doesn't the ingress use spiffeIDTemplate with /ns/xxx/sa/xxx?
There was a problem hiding this comment.
While I was testing the integration I was able to identify that the spiffeid pattern /ns/xxx/sa/xxx is only necessary for workloads, thats why I used this configuration to emphasize this behavior.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alexandrealvino, maxlambrecht, mchurichi, n-th The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Affected functionality
Mithril automatic workload registration
Description of change
Replaces k8s automatic registrar with the new SPIRE Controller Manager
Which Jira task this PR is related to
Jira task
Signed-off-by: Alexandre Alvino [email protected]