Fix Indexable#each_repeated_combination(n) when n > size (crystal…

…-lang#14092)
HertzDevil · Dec 15, 2023 · 1c8a68a · 1c8a68a
1 parent c53dd72
commit 1c8a68a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/spec/std/indexable_spec.cr b/spec/std/indexable_spec.cr
@@ -1,4 +1,5 @@
 require "spec"
+require "spec/helpers/iterate"
 
 private class SafeIndexable
   include Indexable(Int32)
@@ -811,5 +812,10 @@ describe Indexable do
       end
       iter.next.should be_a(Iterator::Stop)
     end
+
+    describe "n > size (#14088)" do
+      it_iterates "#each_repeated_combination", [[1, 1, 1], [1, 1, 2], [1, 2, 2], [2, 2, 2]], SafeIndexable.new(2, 1).each_repeated_combination(3)
+      it_iterates "#each_repeated_combination", [[1, 1, 1, 1], [1, 1, 1, 2], [1, 1, 2, 2], [1, 2, 2, 2], [2, 2, 2, 2]], SafeIndexable.new(2, 1).each_repeated_combination(4)
+    end
   end
 end
diff --git a/src/indexable.cr b/src/indexable.cr
@@ -1483,7 +1483,7 @@ module Indexable(T)
       @copy = array.dup
       @indices = Array.new(@size, 0)
       @pool = @indices.map { |i| @copy[i] }
-      @stop = @size > @n
+      @stop = false
       @i = @size - 1
       @first = true
     end