Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX]: gog setup regression for v1 games #4049

Merged

Conversation

imLinguin
Copy link
Member

On Linux we were looking at the windows version of the path which was always false.

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@imLinguin imLinguin added the pr:ready-for-review Feature-complete, ready for the grind! :P label Oct 9, 2024
@imLinguin imLinguin requested review from a team, arielj, flavioislima, CommandMC and Nocccer and removed request for a team October 9, 2024 09:33
Copy link
Collaborator

@CommandMC CommandMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always have a hard time testing these without an explicit "These games were affected by this issue" list, but I'm gonna assume you know what you're doing

@imLinguin
Copy link
Member Author

We were doing a getWinePath for win variant on this variable. So we were trying to check if C:/ paths exist... on Linux. I guess it doesn't need explanation in certain games

@CommandMC CommandMC merged commit df71f6a into Heroic-Games-Launcher:main Nov 17, 2024
9 checks passed
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Nov 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants