Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make actions_font_family_no_default and content_font_family_no_default more translation-friendly #3880

Conversation

jjanuszkiewicz
Copy link
Contributor

Replace string concatenation with i18n interpolation in actions_font_family_no_default and content_font_family_no_default keys.

This should help eliminate translation errors, as currently many languages have incorrect translation for those keys, even en has an incorrectly placed parenthesis there, resulting in this displayed in UI: Actions Font Family (Default): "Rubik").


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima
Copy link
Member

flavioislima commented Jul 25, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@jjanuszkiewicz
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@jjanuszkiewicz
Copy link
Contributor Author

recheck

Copy link
Collaborator

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

it will require some work from translators to re-add the translation, but it's a needed change to make them better

@jjanuszkiewicz
Copy link
Contributor Author

I thought to add a Polish translation myself, and to add all remaining translations as suggestions, as this is just a technical change and not really any new translation. I can do that as soon as this is merged and pushed to Weblate.

@CommandMC CommandMC merged commit 44c4269 into Heroic-Games-Launcher:main Nov 1, 2024
9 checks passed
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Nov 1, 2024
@jjanuszkiewicz jjanuszkiewicz deleted the improve_font_settings_i18n branch November 23, 2024 12:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants