Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] some issues with sideloads #3767

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[FIX] some issues with sideloads #3767

wants to merge 1 commit into from

Conversation

Etaash-mathamsetty
Copy link
Member

@Etaash-mathamsetty Etaash-mathamsetty commented May 18, 2024 •
edited
Loading

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@a931vwewi a931vwewi mentioned this pull request May 19, 2024
Open
@Etaash-mathamsetty Etaash-mathamsetty added the pr:ready-for-review Feature-complete, ready for the grind! :P label May 28, 2024
@arielj
Copy link
Collaborator

arielj commented Jun 1, 2024

I'm trying to reproduce what you mention of the End of log printed early but I can't reproduce that, I tried 3 sideloaded games and that always happens at the end

arielj
arielj reviewed Jun 1, 2024
View reviewed changes
src/backend/launcher.ts Outdated Show resolved Hide resolved
CommandMC
CommandMC reviewed Jun 25, 2024
View reviewed changes
src/backend/storeManagers/sideload/games.ts Outdated Show resolved Hide resolved
src/backend/launcher.ts Outdated Show resolved Hide resolved
src/backend/launcher.ts Outdated Show resolved Hide resolved
@Etaash-mathamsetty Etaash-mathamsetty removed the pr:ready-for-review Feature-complete, ready for the grind! :P label Sep 20, 2024
@Etaash-mathamsetty Etaash-mathamsetty marked this pull request as draft September 20, 2024 19:46
@Etaash-mathamsetty Etaash-mathamsetty force-pushed the sideload-fixes branch 2 times, most recently from d7cefff to 072355d Compare September 29, 2024 19:45
@Etaash-mathamsetty Etaash-mathamsetty marked this pull request as ready for review September 29, 2024 19:48
@Etaash-mathamsetty Etaash-mathamsetty added the pr:ready-for-review Feature-complete, ready for the grind! :P label Sep 29, 2024
CommandMC
CommandMC reviewed Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@CommandMC CommandMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it stands right now, this PR seems to have a few unrelated changes thrown together, with rather unclear commit messages. Could you squash commits where necessary?

@Etaash-mathamsetty
Copy link
Member Author

ill split this up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CommandMC CommandMC Awaiting requested review from CommandMC

@arielj arielj Awaiting requested review from arielj

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mangohud no longer appears
3 participants
@Etaash-mathamsetty @arielj @CommandMC