-
-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Allow removing elements from recently played #1937
Conversation
Maybe adding a listener to the |
You mean watching the .json file for changes? I think it would work yeah, I wonder how performant that is (not sure how listening for file changes work). What I imagined was that idea of having an events system, so then we can emit the event |
@arielj about performance I think it is fine. |
I just realized when coding this that we store the recently played games in the same file we store other things like favorites, the window size/position, log paths and more. I'll implement the watch for now, but I'll try to improve this after the beta is released EDIT: for some reason, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Tested here and it is working fine.
This PR adds the feature to allow users to remove elements from the Recently Played area manually. Fixes #1319
It adds a few more things:
recent_games
fileThere's one issue that this PR doesn't fix (I'll add a report for it): the list of games in the tray icon menu doesn't get updated on the fly, it needs a restart of Heroic. Fixing that with the current code needs a lot of hacky coupled code between main, the context menu handler and the recently played list, if we implement an event system that's going to be a lot easier and cleaner to do.
Use the following Checklist if you have changed something on the Backend or Frontend: