-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: chain id refactoring #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can you double check if the |
feat: support multiple chains as origin chain
to fully confirm if works, need to resolve HerodotusDev/hdp-cairo#76 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal
ChainId
we want to keep raw value which this heavy coupled with encode/decode, so we stay as integer
in this case we are stick to original chain_id numeric value :
https://github.com/HerodotusDev/hdp/blob/starknet/hdp/src/primitives/chain_id.rs#L94-L110
Userfacing (External)
ChainId
as
SN_SEPOLIA
chain integer value is bad UX, we keep seperate deserialize value target for external userfacing typeFor
request.json
and cli input, we are accepting as this type:https://github.com/HerodotusDev/hdp/blob/starknet/hdp/src/primitives/chain_id.rs#L55-L69
So e.g you could construct request format in this way
:
hdp/request.json
Line 2 in 01332fc
also .env variable will be following external type , don't use 11155111, use ETHEREUM_SEPOLIA