Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

private input with example, with cli refactor #123

Merged
merged 26 commits into from
Aug 13, 2024
Merged

private input with example, with cli refactor #123

merged 26 commits into from
Aug 13, 2024

Conversation

rkdud007
Copy link
Member

@rkdud007 rkdud007 commented Aug 7, 2024 •
edited
Loading

  • private input support
  • private input example
  • cli refactor: overall structure so that example entry point can be simply hdp_run
  • cli refactor: RUST_LOG to control tracing level
  • and some neat pick

@rkdud007 rkdud007 changed the title private input with example private input with example, with cli refactor Aug 12, 2024
@rkdud007 rkdud007 marked this pull request as ready for review August 12, 2024 17:06
@rkdud007 rkdud007 requested a review from Okm165 August 12, 2024 17:17
@Okm165 Okm165 self-requested a review August 12, 2024 18:17
Okm165
Okm165 approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@Okm165 Okm165 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rkdud007 rkdud007 merged commit ceb33b3 into dev Aug 13, 2024
1 check passed
@rkdud007 rkdud007 deleted the private-input branch August 13, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Okm165 Okm165 Okm165 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkdud007 @Okm165