Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #735 check 0 divide, use TimeInt.zero over 0 #736

Merged
merged 4 commits into from
May 6, 2022
Merged

Fixes #735 check 0 divide, use TimeInt.zero over 0 #736

merged 4 commits into from
May 6, 2022

Conversation

JoeMatt
Copy link
Collaborator

@JoeMatt JoeMatt commented May 5, 2022 •
edited
Loading

@JoeMatt JoeMatt self-assigned this May 5, 2022
@JoeMatt JoeMatt requested review from lkzhao, SD10 and kuyazee as code owners May 5, 2022 07:16
@JoeMatt JoeMatt linked an issue May 5, 2022 that may be closed by this pull request
Crash -- HeroViewPropertyViewContext.swift line 56 #735
Closed
@JoeMatt JoeMatt mentioned this pull request May 5, 2022
Closed
@JoeMatt
refs #734 check toView != fromView
e00b904 
Signed-off-by: Joseph Mattello <[email protected]>
@JoeMatt JoeMatt mentioned this pull request May 5, 2022
Open
@JoeMatt
refs #735 cleanup crashing function code
e00bc08 
make loop improvements

Signed-off-by: Joseph Mattello <[email protected]>
@JoeMatt JoeMatt merged commit f9f018d into develop May 6, 2022
@JoeMatt JoeMatt deleted the feature/735_HeroViewPropertyViewContext_Crash branch May 6, 2022 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuyazee kuyazee kuyazee approved these changes

@lkzhao lkzhao Awaiting requested review from lkzhao lkzhao is a code owner

@SD10 SD10 Awaiting requested review from SD10 SD10 is a code owner

Assignees

@JoeMatt JoeMatt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash -- HeroViewPropertyViewContext.swift line 56
2 participants
@JoeMatt @kuyazee