Remove Handle and HandleFactory.

Use an integer array instead of encoding the data into a long which added limitations and made the code more complicate.

apps/desktop/desktop/src/main/java/bisq/desktop/components/cathash/CatHash.java

@@ -30,7 +30,6 @@
 @Slf4j
 public class CatHash {
     private static final int MAX_CACHE_SIZE = 10000;
-    private static final HandleFactory HANDLE_FACTORY = new HandleFactory();
     private static final ConcurrentHashMap<ByteArray, Image> CACHE = new ConcurrentHashMap<>();
 
     public static Image getImage(byte[] pubKeyHash) {
@@ -48,20 +47,16 @@ private static Image getImage(ByteArray pubKeyHash, boolean useCache) {
         BigInteger bigInteger = new BigInteger(pubKeyHash.getBytes());
         Configuration configuration = new Configuration();
         VariableSizeHashing hashing = new VariableSizeHashing(configuration.getBucketSizes());
-        byte[] data = hashing.createBuckets(bigInteger);
-        Handle handle = HANDLE_FACTORY.calculateHandle(data);
-        Image image = imageForHandle(handle, configuration);
+        int[] integerBuckets = hashing.createIntegerBuckets(bigInteger);
+        Image image = imageFromIntegerBuckets(integerBuckets, configuration);
         if (useCache && CACHE.size() < MAX_CACHE_SIZE) {
             CACHE.put(pubKeyHash, image);
         }
         return image;
     }
 
-    private static Image imageForHandle(Handle handle, Configuration configuration) {
-        long ts = System.currentTimeMillis();
-        byte[] bucketValues = handle.bucketValues();
-        String[] paths = configuration.convertToFacetParts(bucketValues);
-        log.debug("Generated paths for CatHash image in {} ms", System.currentTimeMillis() - ts); // typically <1ms
+    private static Image imageFromIntegerBuckets(int[] integerBuckets, Configuration configuration) {
+        String[] paths = configuration.integerBucketsToPaths(integerBuckets);
         return ImageUtil.composeImage(paths, configuration.width(), configuration.height());
     }
 }

apps/desktop/desktop/src/main/java/bisq/desktop/components/cathash/Configuration.java

@@ -56,6 +56,19 @@ public class Configuration {
         };
     }
 
+    public String[] integerBucketsToPaths(int[] integerBuckets) {
+        if (integerBuckets.length != BUCKET_COUNT) {
+            throw new IllegalArgumentException();
+        }
+
+        String[] paths = new String[FACET_COUNT];
+        for (int facet = 0; facet < FACET_COUNT; facet++) {
+            int bucketValue = integerBuckets[facet];
+            paths[facet] = generatePath(FACET_PATH_TEMPLATES[facet], bucketValue);
+        }
+        return paths;
+    }
+
     public String[] convertToFacetParts(byte[] bucketValues) {
         if (bucketValues.length != BUCKET_COUNT) {
             throw new IllegalArgumentException();

apps/desktop/desktop/src/main/java/bisq/desktop/components/cathash/VariableSizeHashing.java

@@ -67,4 +67,17 @@ public byte[] createBuckets(BigInteger hash) {
 
         return ret;
     }
+
+    public int[] createIntegerBuckets(BigInteger input) {
+        int currentBucket = 0;
+        int[] result = new int[bucketSizes.length];
+        while (currentBucket < bucketSizes.length) {
+            BigInteger[] divisorReminder = input.divideAndRemainder(BigInteger.valueOf(bucketSizes[currentBucket]));
+            input = divisorReminder[0];
+            long reminder = divisorReminder[1].longValue();
+            result[currentBucket] = (int) Math.abs(reminder % bucketSizes[currentBucket]);
+            currentBucket++;
+        }
+        return result;
+    }
 }

apps/desktop/desktop/src/main/java/bisq/desktop/overlay/onboarding/create_profile/CreateProfileController.java

@@ -22,8 +22,8 @@
 import bisq.desktop.common.threading.UIThread;
 import bisq.desktop.common.view.Controller;
 import bisq.desktop.common.view.Navigation;
-import bisq.desktop.components.overlay.Popup;
 import bisq.desktop.components.cathash.CatHash;
+import bisq.desktop.components.overlay.Popup;
 import bisq.desktop.overlay.OverlayController;
 import bisq.i18n.Res;
 import bisq.identity.IdentityService;
@@ -153,7 +153,7 @@ private CompletableFuture<ProofOfWork> createProofOfWork(byte[] pubKeyHash) {
                 .thenApply(proofOfWork -> {
                     long powDuration = System.currentTimeMillis() - ts;
                     log.info("Proof of work creation completed after {} ms", powDuration);
-                    createSimulatedDelay(powDuration);
+                    //createSimulatedDelay(powDuration);
                     UIThread.run(() -> {
                         model.setProofOfWork(Optional.of(proofOfWork));
                         String nym = NymIdGenerator.fromHash(pubKeyHash);