Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test lates version #1

Merged
merged 87 commits into from
Feb 29, 2024
Merged

Test lates version #1

merged 87 commits into from
Feb 29, 2024

Conversation

MasherJames
Copy link

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Frontend

Describe the reason for change

(link to issue, supportive screenshots etc.)

What does this fix?

(if this is a bug fix)

What is the new behavior?

(if this is a breaking or feature change)

What is the current behavior?

(if this is a breaking or feature change)

What libraries were added/updated?

(list all with version changes)

Does this change affect performance?

(if so describe the impacts positive or negative)

Does this change affect security?

(if so describe the impacts positive or negative)

What alternative approaches were there?

(briefly list any if applicable)

What feature flags were used to cover this change?

(briefly list any if applicable)

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)

dependabot bot and others added 29 commits February 29, 2024 19:01
…Signal#1599)

Bumps [release-drafter/release-drafter](https://github.com/release-drafter/release-drafter) from 5.24.0 to 5.25.0.
- [Release notes](https://github.com/release-drafter/release-drafter/releases)
- [Commits](release-drafter/release-drafter@v5.24.0...v5.25.0)

---
updated-dependencies:
- dependency-name: release-drafter/release-drafter
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix: LEAP-306: Fix github vulnerabilities

* change ls-frontend-test hash

* change the ls-frontend-test hash

* change import
Create Project modal's preview had broken styles
* fix: LEAP-299: Show spinner while taxonomy's loading

* Fix Cypress

* Remove debug and verbose from e2e

* Fix nested loadings with real api

Global spinner should not be displayed then, only small spinner near the item
* fix: LSDV-1476: Fix selected=true for Taxonomy

First try, not fully working.
Now `<Choice selected="true">` will work inside Taxonomy as well.

* Fix example; typo in FFs; list of taxonomy FFs

- fix example for classifications
- fix typo in FF link
- add list of all Taxonomy and Choices related FFs

* Add test for preselected Taxonomy; with 3617 FF off

* fix work with shared store (FF_DEV_3617)

* Add tests for static/dynamic + on/off cases

* Linting + remove unused alert

* Remove FF_DEV_2007 flag

* Remove FF_DEV_2007_DEV_2008 FF

* Actually use ffState in test

* Remove FF_DEV_2100_A

* Remove FF_DEV_2244

* Linting from prev commits

* Add missing required flags

* Fix TS recognition of cypress globals

* Remove unused FF groupping

Not the best way to do it anyway

* It does work with FF_DEV_3617 after the fix!

* Add comment about fixed updateValue()

* Update ls-frontend-test to have hasNoSelected()

* Fix tests

* Add FF to fix init order

Children should be init before other processes like setDefaultValues()

* Make it safe to `updateValue()` without task

This case can happen during store init in Label Stream,
task will be loaded later.

* Update ls-frontend-test

* Remove flags from tests

* Small fixes for test data

* Connect updated test helpers

* Get rid of unused FF list

* Update ls-frontend-test

---------

Co-authored-by: hlomzik <[email protected]>
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3 to 4.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@v3...v4)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix: LEAP-218: Improve performance of search

* add new tests to see how it works between the original ui and our own search

* working with external input search

* implements new search and fix UI

* split taxonomy and taxonomy search

* add spacing line in the end of the file

* add tests

* change the expandedKeys method from its own method to filterDataTree

* fix tests

* add ff and fix some UX problems

* remove useless function

* expand just the mached value

* fix small bugs and add comments

* stop digging if it doesnt have chindrens

* remove preset ff

* check if is leaf

* Update src/components/NewTaxonomy/NewTaxonomy.tsx

Co-authored-by: hlomzik <[email protected]>

* Update src/components/NewTaxonomy/TaxonomySearch.tsx

Co-authored-by: hlomzik <[email protected]>

* Update src/components/NewTaxonomy/TaxonomySearch.tsx

Co-authored-by: hlomzik <[email protected]>

* Update src/components/NewTaxonomy/TaxonomySearch.tsx

Co-authored-by: hlomzik <[email protected]>

* Update src/components/NewTaxonomy/TaxonomySearch.tsx

Co-authored-by: hlomzik <[email protected]>

* Update src/components/NewTaxonomy/NewTaxonomy.tsx

Co-authored-by: hlomzik <[email protected]>

* change changeValue method name to resetValue

* Update src/components/NewTaxonomy/TaxonomySearch.tsx

Co-authored-by: hlomzik <[email protected]>

---------

Co-authored-by: juliosgarbi <[email protected]>
Co-authored-by: hlomzik <[email protected]>
* feat: LEAP-58: Proxy URL for Taxonomy if possible

onProxyUrl should be provided to LSF from LS.
TODO: can be not the correct way to call it, check how events invoke.

* Add `events` to store to have access anywhere

So events can be triggered and caught by any internal and external code

* additional work to get proxyurl working

* lint + merge fixes

* use new project scoped presigning path

* Update src/stores/AppStore.js

Co-authored-by: hlomzik <[email protected]>

* Update src/tags/control/Taxonomy/Taxonomy.js

Co-authored-by: hlomzik <[email protected]>

* empty commit to trigger build workflow

* trigger CI

---------

Co-authored-by: Jo Booth <[email protected]>
Co-authored-by: MihajloHoma <[email protected]>
* fix: optic-113: draft save on switch history

* set draft saving flag sooner

* fix draft getting stuck

* Update src/components/CurrentEntity/AnnotationHistory.tsx

Co-authored-by: bmartel <[email protected]>

---------

Co-authored-by: bmartel <[email protected]>
* fix: LEAP-16: Add validation to contextual scrolling

* remove leftover console

* remove extra brackets

---------

Co-authored-by: hlomzik <[email protected]>
Co-authored-by: hlomzik <[email protected]>
…umanSignal#1565)

* perf: LEAP-32: Improve performance of zooming at Image Segmentation

* Add missed feature flag

* Fix linting problem

* Use more ff checks

* Use zoom optim ff in tests

* Add tests for image position property

* Update @heartexlabs/ls-test

* Fix eslint warnings

* Update ls-test

* Update ls-test

* Fix e2e tests

* Fix path

* Fix canvasSize in e2e tests

* Fix image position test

* Update ls-test

* Fix timings in test

* Update ls-test

* Update ls-test
…umanSignal#1610)

* fix: LEAP-345: Fix taxonomy items collapsing when dropdown is closed

* fix default expanded keys

* reset the changes and fix the way that its expanding keys

* fix auto focus

* fix comment

* Don't add leaves to expandedKeys

Should have improved performance as well, but no,
after like 20 items in this list it's laggy anyway.

---------

Co-authored-by: hlomzik <[email protected]>
* docs: Small fixes for tag params doc

- Image#valueList moved top
- Image alignment, defaultZoom and crossOrigin params now have list of values
- Paragraphs#audioUrl fixed to be optional
- Paragraphs#sync capitalized

* Update Image.js with small punctuation changes

* Remove incorrect "xpath" note from ParagraphsRegion

---------

Co-authored-by: Caitlin Wheeless <[email protected]>
Co-authored-by: hlomzik <[email protected]>
Update Model.js

Co-authored-by: hlomzik <[email protected]>
Co-authored-by: hlomzik <[email protected]>
fix: optic-142: submit and exit style update
* feat: LEAP-336: Make Ranker cards collapsible

First try with just collapsible items, no design, via react context.

* Move styling and hiding to styles

* Collapse/Expand All in column titles

* Add param `collapsible` default to true

This will allow to disable collapsible items if they are
not a good fit for any reason.
Fix styles to be applied only when it's true.

* Change default styles; better to be more universal by default
…ignal#1577)

* docs: DOC-121: Update taxonomy tag page for external taxonomy

* Added legacy param definition
* fix: LEAP-364: Fix crosshair functionality

* Update ls-test

* Add regerssion test

* Update ls-test
ls-frontend-test is public now, so it doesn't require any auth.
* ci: LEAP-296: Remove SSH Agent from Cypress step

ls-frontend-test is public now, so it doesn't require any auth.

* ci: LEAP-296: Fix link to ls-frontend-test repo

Simple `org/repo#hash` format should work

---------

Co-authored-by: hlomzik <[email protected]>
…l#1593)

chore(deps): bump @babel/traverse from 7.18.2 to 7.23.2 in /e2e

Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.18.2 to 7.23.2.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse)

---
updated-dependencies:
- dependency-name: "@babel/traverse"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: hlomzik <[email protected]>
Expand clickable area by using `label` tag.

Co-authored-by: hlomzik <[email protected]>
Bumps [actions/github-script](https://github.com/actions/github-script) from 6 to 7.
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@v6...v7)

---
updated-dependencies:
- dependency-name: actions/github-script
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix: LEAP-31: Fix functioning of auto annotations

* Add tests

* Fix eslint warnings

* Update ls-test

* Remove Region#revokeSuggestion

* Update ls-test

* Refactor

Co-authored-by: yyassi-heartex <[email protected]>

* Update ls-test

* Add comment

* Update ls-test

* fix deps

---------

Co-authored-by: yyassi-heartex <[email protected]>
Co-authored-by: hlomzik <[email protected]>
hlomzik and others added 24 commits February 29, 2024 19:01
* ci: New PR template

* Fill in all sections; emphasize actions part

* Made some edits for clarity

---------

Co-authored-by: Caitlin Wheeless <[email protected]>
* fix: LEAP-523: Return region's text to item in a list

New Outliner left this important info from region items in the list.
Returning it back.

* Simplify text output in Region Info panel

We don't need to output it via dangerouslySetInnerHTML,
it's not safe and that's just a text, not an html.

* Make "Incomplete polygon/other type" consistent

We had different versions at different places,
assuming that it's always a polygon, but it can be a brush.

* Add test for New UI and regions' texts

* Fix it for different grouppings

With groupping by Label or Tool `item` is undefined

* Remove accidential Scenario.only

* Fix excess symbol

Co-authored-by: Sergey <[email protected]>

---------

Co-authored-by: hlomzik <[email protected]>
Co-authored-by: Sergey <[email protected]>
…ne (HumanSignal#1667)

* fix: LEAP-240: Prevent creating region on clicking outside selected one

* Add tests for clicking outside selected region

* Ensure that unselecting labels and regions was initiated only by click.

Updated the handleDeferredMouseDown method to accept a boolean argument that represents whether the mouse was clicked or not. This modification prevents unwanted deselection of regions and labels by ensuring that this event occurs only when the mouse was clicked and deselection is intentional.

* Add tests for checking labels behaviour

---------

Co-authored-by: Gondragos <[email protected]>
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3.1.4 to 3.1.5.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@v3.1.4...v3.1.5)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…l#1683)

Bumps [peter-evans/create-or-update-comment](https://github.com/peter-evans/create-or-update-comment) from 3 to 4.
- [Release notes](https://github.com/peter-evans/create-or-update-comment/releases)
- [Commits](peter-evans/create-or-update-comment@v3...v4)

---
updated-dependencies:
- dependency-name: peter-evans/create-or-update-comment
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* refactor: LEAP-447: Refactor validation method across control tags

Improved the validation logic in ClassificationBase.js, DateTime.js, and PerRegion.js. Provided distinct validation scenarios for classifications, including per region and per object, and streamlined the date validation in DateTime.js for better precision and simplicity.

* fix: LEAP-447: Improve Number tag validation

The Number model was modified to improve validation logic. 'validateValue' function was added to cover more number validation cases such as minimum, maximum, and step checks. Furthermore, some parameter descriptions were adjusted for better clarity, namely the 'required' parameter definition.

* Improve validation method of Required mixin

Makes it be able to work in chain with other validations

* Add validation for per-item tags

A new feature flag controlled code block was introduced to enable the validation of per-item tags as part of the Classification Base and Per Item Mixin. If the feature flag FF_LSDV_4583 is active and self.peritem is true, the new `_validatePerItem` method is used to validate each region result.

* Update ls-test dependency in functional tests

* Add functional tests for number control tag

This commit introduces functional tests for various configurations of the number control tag. It covers setting and loading of values, validation against min/max and steps, perRegion and perItem validation, and proper error display for each case.

* Fix linting issues

* Fix the accidental deletion of a line of code

* Refactor with simplifying

Co-authored-by: yyassi-heartex <[email protected]>

* Fix linting problems and texts

* Update @heartexlabs/ls-test version

Signed-off-by: Sergey <[email protected]>

* Add comments about new methods and tricky changes

Signed-off-by: Sergey <[email protected]>

* Make validation tests more intuitive

Signed-off-by: Sergey <[email protected]>

* Remove unused import in number.cy

Signed-off-by: Sergey <[email protected]>

* Fix comments for validation methods

Signed-off-by: Sergey <[email protected]>

* Update @heartexlabs/ls-test package version

Signed-off-by: Sergey <[email protected]>

---------

Signed-off-by: Sergey <[email protected]>
Co-authored-by: yyassi-heartex <[email protected]>
…umanSignal#1685)

When both MIG and image preloading are enabled, there was no canvas overlay for the Magic Wand which caused the Magic Wand to fail.

* fix: LSDV-4864: Fix MagicWand in MIG scenario with image preloading

(cherry picked from commit d2330f7)

* Update ls-test dependency

* Fix tests

---------

Co-authored-by: Nick Skriabin <[email protected]>
Co-authored-by: hlomzik <[email protected]>
…1693)

Bumps [peter-evans/slash-command-dispatch](https://github.com/peter-evans/slash-command-dispatch) from 3 to 4.
- [Release notes](https://github.com/peter-evans/slash-command-dispatch/releases)
- [Commits](peter-evans/slash-command-dispatch@v3...v4)

---
updated-dependencies:
- dependency-name: peter-evans/slash-command-dispatch
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3.1.5 to 4.0.1.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@v3.1.5...v4.0.1)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [hmarr/debug-action](https://github.com/hmarr/debug-action) from 2.1.0 to 3.0.0.
- [Release notes](https://github.com/hmarr/debug-action/releases)
- [Commits](hmarr/debug-action@v2.1.0...v3.0.0)

---
updated-dependencies:
- dependency-name: hmarr/debug-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ignal#1690)

Bumps [release-drafter/release-drafter](https://github.com/release-drafter/release-drafter) from 5.25.0 to 6.0.0.
- [Release notes](https://github.com/release-drafter/release-drafter/releases)
- [Commits](release-drafter/release-drafter@v5.25.0...v6.0.0)

---
updated-dependencies:
- dependency-name: release-drafter/release-drafter
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…1697)

Bumps [thehanimo/pr-title-checker](https://github.com/thehanimo/pr-title-checker) from 1.4.1 to 1.4.2.
- [Release notes](https://github.com/thehanimo/pr-title-checker/releases)
- [Commits](thehanimo/pr-title-checker@v1.4.1...v1.4.2)

---
updated-dependencies:
- dependency-name: thehanimo/pr-title-checker
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* docs: LEAP-615: Mention spaces saving for Text tag

Text tag is displayed as html, so all spaces are smashed by browser, and they also go like this to result. To avoid this users can add custom style in config, described in docs. But it only says that this affects displaying, not saving the result. Adding this note as well.

* Very small edit

---------

Co-authored-by: Caitlin Wheeless <[email protected]>
Co-authored-by: hlomzik <[email protected]>
### Main change

**Only one annotation is selected during task opening.**

We have the concept of selecting annotation, when we not just assign it as current one, but also update data in tags, trigger external event, load annotation history, setup hotkeys, set initial values.

Previosly it was required to select every annotation to do some extra work in regions/tags inside it because of some quirky legacy code. I fixed what I found so far and ran all possible tests — they all are green, so consider this change mostly safe.

Benefits:
- improved performance as only one annotation is selected, reducing number of calculations and renders
- no excess network requests to retrieve annotation history for every of these annotations
- more clean code
- one more step to remove one of the oldest legacy concept of `states`: it's not used in init anymore

Things changed:
- `STORE_INIT_OK` global var added to catch tags that can't properly work with new system (edge cases we missed)
- apparently we have only one unit test for tags — Ranker; it's securely mocked

Concerns:
- `states` in Video tag select only *Labels controls, but changed code is in `fixBrokenAnnotation` which will do nothing to Video anyway
- in potential missed edge case app will just crash
- we could potentially check that we are inside init process by some flag, right?

### Other changes
- removed Predictions panel and related code like showAllPredictions
- removed panels from App and down the stream — we don't use them anywhere (3rd party LSF can be affected, but not sure anyone using panels there)
- converted `LabelStudio.js` to TypeScript
- fixed bunch of annoying react warnings (non-html props, wrong values, missed refs)
- started to reorganize our "envs" to get rid of them at some point; for now it's `getRoot()` removed from there
- removed `SidebarPage` as it was useless, plus removed multi-tabs support from `SidebarTabs` as `panels` were not used; plus that's all only for the old interface which is about to be removed
- removed `hydrated` as it's not used anymore after HumanSignal#1166
- changed order of annotations to original one without reversing; thus order will always be the same, fixing the issue when list was reversed again after task reload; visual order is defined in `AnnotationsCarousel` anyway, so no changes in UX
- fixed annotations order in View All to be the same as in annotation tabs



* Remove View All Predictions and anything related

It's not used anymore for a while

* Move LabelStudio to TS, improve a little

- Type drafts for main LSF class
- getRootElement moved from env
- Fixed methods signatures
- Fixed typo in method name

Most of the imports have TS errors because they are not typed;
let it be like this for now.

* Simplify SidebarTabs and remove unused panels param

`panels` were not used anywhere, and this is part of old interface,
that will be removed soon.
+ fix global Htx typing
+ fix conditions in App

* Remove `hydrated`, we don't need it after HumanSignal#1166

* Fix some annoying react warnings

* Don't select every annotation on init

Also don't call any unneccessary methods for render.
Just init regions.

* Add flags to test correct behavior of init

* Fix Relation init

* fix our fixBrokenAnnotation() method

Don't use states(), we already have simple toNames

* Some other small fixes

React warnings, simplier code

* Fix merged results - they can also use toNames

This is needed only for Video rectangles

* Temporary fix for unit tests

We don't have a real init, so overpass it

* Fix history reinit for some cases

Should fix failed e2e with TimeSeries, Audio and Video

* Fix annotation selected by default: should be 1st one

Annotations added to the start of the list, so the last one added
is the first one in the list and is selected by default

* Remove unused Annotation#update model prop

* Add feature flag to cover annotation select

* Fix FF name

* Add a description for this FF

* Add doc with lot of investigations

* Tiny fix for panel classnames

no extra whitespaces

* Fix from HumanSignal#1665

* Fix typos in LSF.init.md

* Trigger LS build

* Fix typo to trigger LS build again

* Move simpleInit to volatile

This allows to check FF indirectly in other apps

* Add more info about TopBar

* Add couple of deprecation messages

* Stop reversing annotations list

Reversing the list caused problems when task is reloaded and list is reversed again.
The visual order is defined in AnnotationsCarousel, so technical order is not that important.
View All used technical order which can cause discomfort when you see different order
in different places. So that was also fixed.
Everything is behind the same FF, without it the order is an old one, reversed.

* Move annotations ordering to utilities; sort imports

* Fix annotation selected after View All

---------

Co-authored-by: hlomzik <[email protected]>
* Adjust test to fail with required + skipDuplicates

* Fix test to really see the problem

* Run only this test for now

* Rename validateValue in Textarea to fix validation

This method is used to validate text when it's added by user,
not to validate the entire value of Textarea result, it has different signature.
We could adjust it to validate duplicated texts on submit, but that's improvement
and we need just a fix right now.

* Return all tests

* Unrelated doc for displayMode param + fix FF comment

* Fix linting and line endings in some tests

ocr + textarea.skip-duplicates

* Fix Textarea editing

* One more missed thing
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.0.1 to 4.0.2.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@v4.0.1...v4.0.2)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix: LEAP-740: Don't use destroy = null

There are external places that can call destroy unconditionally,
so having it uninitialized is dangerous and leads to app crash.

* Fail E2E test if Image is not loaded

* Revert destroy() behavior to original one

* Trigger CI

* Skip failing tests for now (until HumanSignal#1708)
@dreww6262 dreww6262 merged commit cabb8ad into master Feb 29, 2024
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.