Toast #116
Toast #116
Conversation
|
Deploy preview for helix-react ready! Built with commit de927b9 |
| @@ -5,12 +5,12 @@ import useEventListener from '../hooks/useEventListener'; | |||
| const Alert = ({ onOpen, onClose, className, children, onDismiss, onSubmit, ...rest }) => { | |||
| const hxRef = useEventListener({ onDismiss, onSubmit }); | |||
| return ( | |||
| <> | |||
| <div> | |||
There was a problem hiding this comment.
noticed <> elements don't fix the disappearing react element error.
There was a problem hiding this comment.
@nicko-winner, sorry what's this error again? Does the <> cause the error on render?
There was a problem hiding this comment.
The error happens after helix removes the element from the DOM (by clicking dismiss), and you change pages in storybook. This is the error:
There was a problem hiding this comment.
Ok thanks for the explanation. This helps alot. 👍
| @@ -5,12 +5,12 @@ import useEventListener from '../hooks/useEventListener'; | |||
| const Alert = ({ onOpen, onClose, className, children, onDismiss, onSubmit, ...rest }) => { | |||
| const hxRef = useEventListener({ onDismiss, onSubmit }); | |||
| return ( | |||
| <> | |||
| <div> | |||
There was a problem hiding this comment.
@nicko-winner, sorry what's this error again? Does the <> cause the error on render?
| @@ -5,12 +5,12 @@ import useEventListener from '../hooks/useEventListener'; | |||
| const Alert = ({ onOpen, onClose, className, children, onDismiss, onSubmit, ...rest }) => { | |||
| const hxRef = useEventListener({ onDismiss, onSubmit }); | |||
| return ( | |||
| <> | |||
| <div> | |||
There was a problem hiding this comment.
Ok thanks for the explanation. This helps alot. 👍
Add Toast component