Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"What is the width of the opening" allows a maximum of 9.99 meter, not enough #628

Closed
ratti opened this issue Aug 31, 2024 · 3 comments
Closed
Labels
bug Something isn't working

Comments

@ratti
Copy link

ratti commented Aug 31, 2024

The question "What is the width of the opening" allows a maximum of 9.99 meter, which is not enough for industrial entrances, flood protection gates etc.

How to Reproduce
Find that question somewhere, try to answer i.e. "18". Higest number I can type is 9.99 , not 10.

Expected Behavior
While some validation is useful, hangars or flood gates should be possible.

Does it happen in normal StreetComplete?
It looks like SCEE merged this feature from a SC alpha I can't test.

Versions affected
SCEE 58.22
SC: I can see people discussing this in threads related to 59.0-alpha, but I run 58.2 and don't have that feature.

@ratti ratti added the bug Something isn't working label Aug 31, 2024
@mnalis
Copy link
Collaborator

mnalis commented Sep 1, 2024

Can you give an example object where that happens (i.e. where you needed to tag more 9.99m)?

SC: I can see people discussing this in threads related to 59.0-alpha, but I run 58.2 and don't have that feature.

Yes, the quest is present only in StreetComplete v59.0-alpha1 and newer.

So it would be best if you @ratti could report the issue there (and only if it won't be resolved there ask for it here). Any code change that can be made upstream in vanilla StreetComplete, makes a life of SCEE maintainers much easier, especially in the long run!

While some validation is useful, hangars or flood gates should be possible.

How are those even tagged in OpenStreetMap? Is the quest being asked on them, i.e.:

barrier ~ gate|entrance|sliding_gate|swing_gate|wicket_gate|bollard|block
or barrier = cycle_barrier and cycle_barrier ~ single|diagonal

@ratti
Copy link
Author

ratti commented Sep 1, 2024

Hello,

Can you give an example object where that happens (i.e. where you needed to tag more 9.99m)?

I guess we can skip the part where I search for specific nodes, by just giving some examples where I had that issue. I was mapping in the Hamburg industrial port area, and I got asked that question on…:

  • Stormflood barriers going across multiple road lanes
  • Entrances to heavy industrial companies
  • Airport hangar doors for jumbo jets
  • I didn't come across that, but I guess at the ocean coast there even might be “gates“ wider than 100 meters, wild guess.

This is a photo I made some time ago:
SCR-20240901-mrhb
That's the flood protection barrier for Hamburg Neumühlen, and it's a “small“ one ;-)

To be honest, I found it a bit irritating to get that question asked with a wheelchair symbol refering to the main entrance of a steel factory.

[EDIT]: Yes, I'll make a ticket with SC.

@mnalis
Copy link
Collaborator

mnalis commented Sep 1, 2024

Thanks, fixed upstream in streetcomplete@ef4d703 - next release should have it!

@mnalis mnalis closed this as completed Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants