don't crash if quest is not in questTypeRegistry

fixes #639
Helium314 · Sep 6, 2024 · 8ae245b · 8ae245b
1 parent 438503d
commit 8ae245b
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/...ain/java/de/westnordost/streetcomplete/screens/settings/quest_selection/QuestSelection.kt b/...ain/java/de/westnordost/streetcomplete/screens/settings/quest_selection/QuestSelection.kt
@@ -9,5 +9,7 @@ import de.westnordost.streetcomplete.data.quest.QuestTypeRegistry
 
 data class QuestSelection(val questType: QuestType, var selected: Boolean, val enabledInCurrentCountry: Boolean, val prefs: Preferences) {
     fun isInteractionEnabled(questTypeRegistry: QuestTypeRegistry) = prefs.getBoolean(Prefs.EXPERT_MODE, false)
-        || (questType !is OsmNoteQuestType && questTypeRegistry.getOrdinalOf(questType)!! < EE_QUEST_OFFSET)
+        // not sure how questTypeRegistry can be empty / not contain a quest initially coming from that repository
+        // but it can happen, so just don't crash, see https://github.com/Helium314/SCEE/issues/639
+        || (questType !is OsmNoteQuestType && (questTypeRegistry.getOrdinalOf(questType) ?: EE_QUEST_OFFSET) < EE_QUEST_OFFSET)
 }