Skip to content

Commit

Permalink
update tag editor suggestions
Browse files Browse the repository at this point in the history
  • Loading branch information
Helium314 committed Sep 26, 2023
1 parent f9ae9ac commit 38253f1
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 5 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ SCEE has more permissions than StreetComplete: `ACCESS_BACKGROUND_LOCATION` and
* Some of the settings below can only be enabled in expert mode
* Quest settings for most quests, mostly for customized element selection, but also for other things like allowing generic paved surface answer without note
* Such customization should be handled with care. There are some safeguards, but modifying element selection could still lead to inappropriate tagging, quests being asked over and over again, and maybe app crashes.
* Quests without settings need to be handled individually. Please open an issue if you want specific settings.
* UI settings
* Quick settings button for switching preset, background and reverse quest order. Also contains a level filter for displayed quests / overlay elements
* Quick selector for overlays (on main screen)
Expand Down

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion app/src/main/assets/tag_editor/valueSuggestionsByKey.json

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -242,10 +242,10 @@ class EditTagsAdapter(

// suggestions should not be cluttered with all those address tags, but we don't want to ignore them completely
// but we want to ignore some refs, and building which shows up for shops, but is usually not a good idea because we ignore geometry
val fieldsMoveToEnd = fieldSuggestions.filter { it.startsWith("addr:") || it.startsWith("ref:") }
val fieldsMoveToEnd = fieldSuggestions.filter { it.startsWith("addr:") || it.startsWith("ref:") || it.startsWith("tiger:") }
fieldSuggestions.removeAll(fieldsMoveToEnd)
fieldSuggestions.removeAll { it.startsWith("{") } // appeared in the latest presets update, maybe we should actually go deeper for this '{'?
val moreFieldsMoveToEnd = moreFieldSuggestions.filter { it.startsWith("addr:") || it.startsWith("ref:") }
val moreFieldsMoveToEnd = moreFieldSuggestions.filter { it.startsWith("addr:") || it.startsWith("ref:") || it.startsWith("tiger:") }
moreFieldSuggestions.removeAll(moreFieldsMoveToEnd)
moreFieldSuggestions.removeAll { it.startsWith("{") }

Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/raw/changelog_ee.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
v54.1: |
<ul>
<li>Other answer for name quest: it has a brand name</li>
<li>Don't use deprecated tag for wells in service building quest, thanks to @mcliquid (#455)</li>
<li>Don't use deprecated tag for wells in the service building quest, thanks to @mcliquid (#455)</li>
<li>Additional roof shapes, icons by @mxdanger (#450)</li>
<li>Update translations, thanks to Oil_Station (Chinese), @mcliquid (German), lejun (French), gallegonovato (Spanish)</li>
<li>Small fixes and improvements</li>
Expand Down

0 comments on commit 38253f1

Please sign in to comment.