Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Estonian layout #693

Merged
merged 1 commit into from
Apr 20, 2024
Merged

Conversation

tenextractor
Copy link
Contributor

Current Estonian layout does not have Õ as a separate key even though it is part of the Estonian alphabet. This PR adds a key for Õ to the right of M as shown.
image

@Helium314
Copy link
Owner

Is this a normal Estonian layout and/or wanted by other users?

On AOSP / LineageOS keyboard the layout has been like that for more than 10 years as far as I know, and I don't want to change what people might have used for a long time, based on a single user's feedback.

@tenextractor
Copy link
Contributor Author

@Helium314 This is the layout used by Gboard and the first result on Google Play that comes up when searching 'estonian keyboard layout' (com.estonian.language.keyboard.app). The letter Õ is given a separate key even in computer keyboard layouts.

@Helium314
Copy link
Owner

It's in a quite different place on computer layout, see https://en.wikipedia.org/wiki/List_of_QWERTY_keyboard_language_variants#/media/File:KB_Estonian.svg
I looked through some screenshots of Estonian phone keyboards, and it seems most actually have the Õ at the same place as the PC layout (and some more keys in the bottom row).

But I guess your proposal it's ok considering that layout also exists, and that the placement next to Ü in my opinion results in an awkward layot.

@tenextractor
Copy link
Contributor Author

Keys on a physical keyboard are fixed width so adding a key to the side doesn't affect the other keys. But on mobile the entire keyboard is fixed width and every key we add makes the other keys narrower and harder to hit effectively. For this reason it's better to maintain a maximum of 11 keys per row in my opinion and adjust PC layouts according to this goal. This is why the Gboard layout has Õ on the third row.

@Helium314
Copy link
Owner

I'll merge this, but might revert if there is feedback of several people preferring the old layout.

@Helium314 Helium314 merged commit 6549fd3 into Helium314:main Apr 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants