Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "About" page on 'Settings' #6

Merged
merged 5 commits into from
Jul 8, 2023
Merged

Added "About" page on 'Settings' #6

merged 5 commits into from
Jul 8, 2023

Conversation

RHJihan
Copy link
Contributor

@RHJihan RHJihan commented Jul 6, 2023

The version number is not automatically retrieved. version_text string doesn't work. So, the version number on the About page should be updated manually before any release.

The version number is not automatically retrieved. version_text string doesn't work. So, the version number on the About page should be updated manually before any release.
@RHJihan RHJihan marked this pull request as ready for review July 6, 2023 05:59
@RHJihan
Copy link
Contributor Author

RHJihan commented Jul 7, 2023

I have updated the android:summary for App Slogan to strings.
https://github.com/Helium314/openboard/blob/98627a255b06555e61cc981be7467d8df15b2756/app/src/main/res/xml/prefs_screen_about.xml#L25

But I am having trouble retrieving the version number after configuring the AboutFragment.java, App crashes while opening the About page. Would you look after this?

@RHJihan
Copy link
Contributor Author

RHJihan commented Jul 8, 2023

Configured AboutFragment.java to make use of BuildConfig.VERSION_NAME. Works fine now.

@Helium314 Helium314 merged commit 3f3a2c4 into Helium314:new Jul 8, 2023
@Helium314
Copy link
Owner

I updated the links to point to this repository, otherwise it's good.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants