Add layout of Gujarati language

[ghost]

There is no layout of Gujarati language in the current version. Dictionary would not be required tho. I am not sure how new layouts can be added. If it requires only translations without any technical knowledge, I can contribute.

[Helium314]

See https://github.com/Helium314/openboard/blob/new/layouts.md for how to add layouts.
If you can provide such a layout, I can properly add it to the app, so it uses the correct language.

[ghost]

I have tried to create layout text file as in mentioned in the link you shared. There are too many characters to fit in layout and there's no "capital" or "small" letters in Gujarati, very similar to Hindi language, so I think we can use shift key Off for page-1, shift key On for page-2? I don't know how to use that in layout, I also checked Hindi language layout but it wasn't much help, so I tried to create two separate files for shift key On and for shift key Off. The order of characters should be consistent with any other layouts? If not, then i tried to create a layout similar to GBoard Gujarati layout. Please have a look at two txt files.
SHIFTKEY_ON(final).txt
SHIFTKEY_OFF(final).txt
For currency, "₹" is universally used symbol in India, but there used to be gujarati symbol for rupee as "૱" which you can add into currency I guess. And for numbers, this is equivalent Modern English numbers in following txt.
Numbers.txt

[Helium314]

If it's different for shift, a json layout file is necessary, see e.g. https://github.com/Helium314/openboard/blob/new/app/src/main/assets/layouts/hindi.json where a key has two entries, for shifted state and for default.
If you want to add popup keys, you can add , "popup": { "main": { "label": "*" } }, like done in https://github.com/Helium314/openboard/blob/new/app/src/main/assets/layouts/korean_sebeolsik_final.json

I can do this, but it may take a while until I find time for it.

[ghost]

I have created a json file as per your instructions from other two links. Please verify syntax validity. I have added rupee symbol for gujarati as one of the pop-ups, so no need to add it in currency pop-up. I already provided gujarati numbers file in previous comment.
Gujarati_layout(final).json

[Helium314]

Thanks, I'll have a look at this tomorrow.

[ghost]

Pop-up keys on line 67 , 75, 79 are not visible for me on my android phone (android 8.1). Please verify if they are visible or not on newer android version. They are visible on linux tho.

[Helium314]

Android 8 supports Unicode 9.0, but some characters were added in 10.0.

[Helium314]

Maybe there is some other issue. On Android 9 it should work, but doesn't for me.

[Helium314]

You can try this version: openboard_1.4.5-release.zip.
Numbers are still missing.

Is anything else needed for the layout? Like a ZWNJ key, or a different symbol instead of .?

[ghost]

Alright, I tried apk you shared above. Almost everything works as intended, except following points ;

1. Numbers in main number row and numpad.
   
   
2. There's no rupee symbol in (?123) menu as "₹", instead it shows "$".
   
3. The characters which looks smaller than others (4 characters in the middle in second row) in following (first screenshot) also doesn't work as intended. The output should be similar to the second row (second screenshot) but instead of joining with previous character, they are just standalone.
   
   
4. There are other small characters too in shift key ON state, but they work as intended.
   

My thoughts :

• The rupee symbol should be the default currency in this language instead of $.
• For some characters not working properly, I can try new json file, now using latest android and Gboard rather than on LibreOffice on linux. I will provide new json file shortly.

[ghost]

Alright. I submit new json file with faulty characters from different source. Lets see if it works. Can you also provide me compiled apk for this?
gujarati_layout_1.json
EDIT : This following one should definitely work because I used GBoard and created it on my android 8.1, I also removed unsupported ones and made few changes as well
gujarati_layout_2.json

[Helium314]

openboard_1.4.5-release.zip with gujarati_layout_2.json
I had to revert the change in line 51, because a popup key cannot have an empty label.
The last key is the same for shift and default state. If this is correct, there is actually no need for a shift_state_selector.

[ghost]

Yeah, that was by mistake left blank. Everything looks great and works as intended. Just one small problem. Few characters still looks smaller than others in keyboard layout but works normal as others (as intended). Any idea why is it like this? or how to fix this?

Also one another request, can you change label of key (?123) to (?૧૨૩) (similarly as have done in hindi?)
Following is final edited json file. Now only issue left, is those smaller characters i mentioned.
gujarati_layout_3.json

[Helium314]

can you change label of key (?123) to (?૧૨૩)

Only this, or also for ABC key?

[ghost]

Yes also for ABC use કખગ and . is punctuation mark as usual.

[Helium314]

Normally the key text is reduced in size if it's more than one character. It sometimes starts reducing text size too early. In this case, a labelFlag can be added (done).