-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gh actions integration testing #348
Merged
dgarciabriseno
merged 27 commits into
Helioviewer-Project:main
from
dgarciabriseno:main
Dec 15, 2023
Merged
Fix gh actions integration testing #348
dgarciabriseno
merged 27 commits into
Helioviewer-Project:main
from
dgarciabriseno:main
Dec 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I deleted the monolithic container to use compose instead, this broke CI and the new set of containers didn't support testing.
This patch updates the
php.yml
file to run docker compose to spin up the dev containers via thecompose.yaml
file on themain
branch of thehelioviewer.org-docker
repo. Using the tip of main means it'll always use the latest version of the container environment.The dev container mounts the
api
folder in the current directory. Github actions sets the current working directory to the root of the api repo. So the setup is to cd up a directory, run compose to start the containers, wait for them to be ready, then run the tests inside the api container.Other changes were needed to support this, the test data had to be updated since by default the container only has jp2 image. During setup it downloads 10 images used in the updated unit tests.
When images are downloaded,
daemon.py
tries to change their file owner/permissions to thehelioviewer
group which may not exist. Instead of this causing the download to fail, it now just emits a warning. Which is ok for the containers which do not have permission to do this.