Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gh actions integration testing #348

Merged
merged 27 commits into from
Dec 15, 2023

Conversation

dgarciabriseno
Copy link
Contributor

@dgarciabriseno dgarciabriseno commented Dec 15, 2023

I deleted the monolithic container to use compose instead, this broke CI and the new set of containers didn't support testing.

This patch updates the php.yml file to run docker compose to spin up the dev containers via the compose.yaml file on the main branch of the helioviewer.org-docker repo. Using the tip of main means it'll always use the latest version of the container environment.

The dev container mounts the api folder in the current directory. Github actions sets the current working directory to the root of the api repo. So the setup is to cd up a directory, run compose to start the containers, wait for them to be ready, then run the tests inside the api container.

Other changes were needed to support this, the test data had to be updated since by default the container only has jp2 image. During setup it downloads 10 images used in the updated unit tests.
When images are downloaded, daemon.py tries to change their file owner/permissions to the helioviewer group which may not exist. Instead of this causing the download to fail, it now just emits a warning. Which is ok for the containers which do not have permission to do this.

@dgarciabriseno dgarciabriseno merged commit a170694 into Helioviewer-Project:main Dec 15, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant