Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address the constant issue and use kind_phys for sfcdif4 #41

Merged
merged 1 commit into from
May 26, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions physics/module_sf_noahmp_glacier.f90
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ subroutine noahmp_glacier (&
thsfc_loc ,prslkix ,prsik1x ,prslk1x , &
psfc ,pblhx ,iz0tlnd ,itime , &
sigmaf1 ,garea1 ,psi_opt , & ! in :
ep_1 ,ep_2 ,cp , &
qsnow ,sneqvo ,albold ,cm ,ch ,isnow , & ! in/out :
sneqv ,smc ,zsnso ,snowh ,snice ,snliq , & ! in/out :
tg ,stc ,sh2o ,tauss ,qsfc , & ! in/out :
Expand Down Expand Up @@ -174,6 +175,9 @@ subroutine noahmp_glacier (&

real (kind=kind_phys) , intent(in) :: psfc ! surface pressure
real (kind=kind_phys) , intent(in) :: pblhx ! pbl height
real (kind=kind_phys) , intent(in) :: ep_1
real (kind=kind_phys) , intent(in) :: ep_2
real (kind=kind_phys) , intent(in) :: cp
integer , intent(in) :: iz0tlnd !
integer , intent(in) :: itime !< timestep

Expand Down Expand Up @@ -286,6 +290,7 @@ subroutine noahmp_glacier (&
tbot ,zbot ,zsnso ,dzsnso ,sigmaf1 ,garea1 , & !in
thsfc_loc ,prslkix ,prsik1x ,prslk1x , & !in
psfc ,pblhx ,iz0tlnd ,itime ,psi_opt , &
ep_1, ep_2, cp, &
tg ,stc ,snowh ,sneqv ,sneqvo ,sh2o , & !inout
smc ,snice ,snliq ,albold ,cm ,ch , & !inout
#ifdef CCPP
Expand Down Expand Up @@ -418,6 +423,7 @@ subroutine energy_glacier (nsnow ,nsoil ,isnow ,dt ,qsnow ,rhoair
tbot ,zbot ,zsnso ,dzsnso ,sigmaf1 ,garea1 , & !in
thsfc_loc ,prslkix ,prsik1x ,prslk1x , & !in
psfc ,pblhx ,iz0tlnd ,itime ,psi_opt , &
ep_1, ep_2, cp, &
tg ,stc ,snowh ,sneqv ,sneqvo ,sh2o , & !inout
smc ,snice ,snliq ,albold ,cm ,ch , & !inout
#ifdef CCPP
Expand Down Expand Up @@ -469,6 +475,9 @@ subroutine energy_glacier (nsnow ,nsoil ,isnow ,dt ,qsnow ,rhoair

real (kind=kind_phys) , intent(in) :: pblhx !< PBL height (m)
real (kind=kind_phys) , intent(in) :: psfc !< surface pressure
real (kind=kind_phys) , intent(in) :: ep_1
real (kind=kind_phys) , intent(in) :: ep_2
real (kind=kind_phys) , intent(in) :: cp
integer , intent(in) :: iz0tlnd !< z0t option
integer , intent(in) :: itime !< integration time

Expand Down Expand Up @@ -584,7 +593,7 @@ subroutine energy_glacier (nsnow ,nsoil ,isnow ,dt ,qsnow ,rhoair
eair ,stc ,sag ,snowh ,lathea ,sh2o , & !in
thsfc_loc ,prslkix ,prsik1x ,prslk1x , &
psfc ,pblhx ,iz0tlnd ,itime ,uu ,vv , &
sigmaf1 ,garea1 ,psi_opt , & !in
sigmaf1 ,garea1 ,psi_opt ,ep_1, ep_2, cp, & !in
#ifdef CCPP
cm ,ch ,tg ,qsfc ,errmsg ,errflg , & !inout
#else
Expand Down Expand Up @@ -1022,7 +1031,7 @@ subroutine glacier_flux (nsoil ,nsnow ,emg ,isnow ,df ,dzsnso
eair ,stc ,sag ,snowh ,lathea ,sh2o , & !in
thsfc_loc ,prslkix ,prsik1x ,prslk1x , &
psfc ,pblhx ,iz0tlnd ,itime ,uu ,vv , &
sigmaf1 ,garea1 ,psi_opt , & !in
sigmaf1 ,garea1 ,psi_opt ,ep_1, ep_2, cp, & !in
#ifdef CCPP
cm ,ch ,tgb ,qsfc ,errmsg ,errflg , & !inout
#else
Expand Down Expand Up @@ -1078,6 +1087,9 @@ subroutine glacier_flux (nsoil ,nsnow ,emg ,isnow ,df ,dzsnso

real (kind=kind_phys) , intent(in) :: pblhx !<
real (kind=kind_phys) , intent(in) :: psfc !<
real (kind=kind_phys) , intent(in) :: ep_1
real (kind=kind_phys) , intent(in) :: ep_2
real (kind=kind_phys) , intent(in) :: cp
integer , intent(in) :: iz0tlnd !<
integer , intent(in) :: itime !< integration time
real (kind=kind_phys) , intent(in) :: uu !<
Expand Down Expand Up @@ -1266,6 +1278,7 @@ subroutine glacier_flux (nsoil ,nsnow ,emg ,isnow ,df ,dzsnso

call sfcdif4(1 ,1 ,uu ,vv ,sfctmp , & !allow location for use in the driver
sfcprs ,psfc ,pblhx ,gdx ,z0m , &
ep_1, ep_2, cp, &
itime ,snwd ,1 ,psi_opt, &
tgb ,qair ,zlvl ,iz0tlnd,qsfc , & ! use zlvli?
h ,qfx ,cm ,ch ,ch2 , & ! ch2 = cq2 most of times
Expand Down
Loading