Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show C'Thun as a minion (on ritual) #146

Merged
merged 1 commit into from
Oct 1, 2016
Merged

Show C'Thun as a minion (on ritual) #146

merged 1 commit into from
Oct 1, 2016

Conversation

azeier
Copy link
Member

@azeier azeier commented Sep 24, 2016

closes #137

beheh
beheh requested changes Sep 26, 2016
View reviewed changes
Copy link
Collaborator

@beheh beheh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also hide the exhaustion "Zzz", e.g. by checking the Zone in Entity.isAsleep.

beheh
beheh requested changes Sep 26, 2016
View reviewed changes
Copy link
Collaborator

@beheh beheh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please add a changelog entry.

@azeier
Copy link
Member Author

azeier commented Sep 28, 2016

Implemented those changes.

The IsAsleep solution is a bit more hacky but keeps all the changes in one place and is less likely to have sideeffects. We can go with your approach if you prefer.

@beheh
Copy link
Collaborator

beheh commented Oct 1, 2016

That's fine.

@beheh beheh merged commit 24ae170 into master Oct 1, 2016
@beheh beheh deleted the issue/137 branch October 1, 2016 10:02
@beheh beheh restored the issue/137 branch October 1, 2016 10:10
@beheh beheh deleted the issue/137 branch October 1, 2016 10:12
@beheh beheh restored the issue/137 branch March 25, 2017 19:07
@beheh beheh deleted the issue/137 branch March 25, 2017 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beheh beheh beheh approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show C'Thun as minion instead of card
2 participants
@azeier @beheh