Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to detect The Coin entity #163

Closed
jleclanche opened this issue Oct 8, 2016 · 1 comment
Closed

Attempt to detect The Coin entity #163

jleclanche opened this issue Oct 8, 2016 · 1 comment
Assignees
@beheh
Labels
enhancement

Comments

@jleclanche
Copy link
Member

https://hsreplay.net/replay/N6fQX5eCpWAisBDjUpEBha

It's interesting we hit that. We can very likely figure the coin out:

  • FULL_ENTITY directly into ZONE == HAND
  • Game STEP is null
  • CONTROLLER is not FIRST_PLAYER
  • ZONE_POSITION == 5

If it meets all these, then the oracle can make a safe guess about the coin, I think. It does have to meet all of them just to make sure we don't mistakenly hit a tavern brawl or some such.
beheh added a commit that referenced this issue Oct 10, 2016
@beheh
Improve cardClass and cardType metadata fallback
a8245b7 
Works towards #163.
beheh added a commit that referenced this issue Oct 10, 2016
@beheh
Add GameState.getPlayer(playerId: number): Player
05a5daf 
Works towards #163.
@beheh beheh closed this as completed in 72ffd4c Oct 10, 2016
@beheh beheh self-assigned this Oct 10, 2016
@beheh
Copy link
Collaborator

beheh commented Oct 10, 2016

Superseeds the fix for #85 (3bc6d08).

@beheh beheh mentioned this issue Oct 10, 2016
Closed
beheh added a commit that referenced this issue Oct 10, 2016
@beheh
Attempt to reveal the coin even when not played
b01c7bd 
Closes #163.
@beheh beheh modified the milestone: 1.0.0 Oct 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beheh beheh

Labels
enhancement
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jleclanche @beheh