Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Revamp #325

Merged
merged 40 commits into from
Jan 15, 2022
Merged

feat: Revamp #325

merged 40 commits into from
Jan 15, 2022

Conversation

Hazmi35
Copy link
Owner

@Hazmi35 Hazmi35 commented Dec 17, 2021 •
edited
Loading

TODO:

  • Find a better solution for removed files in 3cd0434
  • Add "Suggestions" rules
  • Add "Layout & Formatting" rules
  • Add "node" / Node.js environment version
  • Add TypeScript version
  • Do the TODOs
  • Reconsider the severity of the rules (warn or error)
  • Reconsider the severity of omitted recommended rules (warn or error)
  • Recheck everything is done
  • Test, then recheck again.

@Hazmi35 Hazmi35 changed the title feat: Update semver range for peer dependencies feat: Revamp Dec 17, 2021
@Hazmi35 Hazmi35 marked this pull request as draft December 17, 2021 11:29
@Hazmi35 Hazmi35 linked an issue Dec 17, 2021 that may be closed by this pull request
@hazmi35/eslint-config's first revamp #179
Closed
@Hazmi35 Hazmi35 force-pushed the feat/revamp branch 3 times, most recently from d9fc6e4 to 30d515c Compare December 23, 2021 14:33
@Hazmi35 Hazmi35 force-pushed the feat/revamp branch 2 times, most recently from 2428768 to e9451e6 Compare January 5, 2022 13:09
@Hazmi35 Hazmi35 marked this pull request as ready for review January 13, 2022 18:14
Hazmi35 added 21 commits January 14, 2022 01:18
@Hazmi35
feat: Update semver range for peer dependencies
a6d5b66
@Hazmi35
feat: Add rules for possible problems
f20f580
@Hazmi35
chore: remove these file temporarily
8249a17
@Hazmi35
chore(deps): Upgrade ESLint to v8.5.0
74e7b48
@Hazmi35
fix(possible-problems): Set this to error instead of warn
d0b75a5
@Hazmi35
feat(Suggestions): Add Suggestions rules
58fac15
@Hazmi35
feat(Layout-and-Formatting): Add Layout and Formatting rules
e3b6537
@Hazmi35
feat: Add these files back
e62b554 
TypeScript support revamp soon
@Hazmi35
fix: Use strip-json-comments to strip comments in .eslintrc.json
70880e8
@Hazmi35
feat(typescript): TypeScript version!
8fa433c
@Hazmi35
fix(typescript): Better extensionRules handler
54033e2
@Hazmi35
fix(base): Add 'no-shadow' rule
f11ff90
@Hazmi35
revert: "fix(typescript): Better extensionRules handler"
9f75915 
This reverts commit 82fd737.
@Hazmi35
fix(typescript): The REAL Better infer handler
6a26709
@Hazmi35
chore(typescript): Add a comment there
a6c165b
@Hazmi35
chore(typescript): Fix typo
ec58a43
@Hazmi35
fix(typescript): Handle inferredButUndefined
3e13009
@Hazmi35
fix(typescript): Remove extensionRules that doesn't exists in baseRules
9226870
@Hazmi35
fix(typescript): Don't remove extensionRules that is not inferred
cfc83b6
@Hazmi35
fix: Always suggest "return await" for better stack trace information
fd64357 
This will set "@typescript-eslint/return-await" rule to warn
And rule "no-return-await" will be turned off in the base rules.

It is done because for better stack trace information as well as for consistent error handling

REFS:
https://typescript-eslint.io/rules/return-await
typescript-eslint/typescript-eslint#994 (comment)
eslint/eslint#12246
https://eslint.org/docs/rules/no-return-await
@Hazmi35
chore(base): Add todo here
25cb0e9
Hazmi35 added 13 commits January 14, 2022 01:26
@Hazmi35
fix(typescript): naming-convention
4242ee7
@Hazmi35
feat(typescript): Disable no-non-null-assertion
a32a2f0
@Hazmi35
fix(typescript): Static methods after normal method
248865b
@Hazmi35
fix(typescript): Static fields after normal fields
a053f24
@Hazmi35
fix(main): Set max-len to 180
8e8271d
@Hazmi35
fix: set @typescript-eslint/no-non-null-asserted-optional-chain to wa…
9f8055f 
…rn and remove no-param-reassign
@Hazmi35
fix(main): Set max-depth to 5 and remove default-case rule
b446ff2
@Hazmi35
fix(main): Remove no-return-assign
ec757e7
@Hazmi35
fix(main): Remove consistent-return
36814a2
@Hazmi35
fix(typescript): Set no-misused-promises to warn and set checksVoidRe…
eae168f 
…turn option to false
@Hazmi35
fix(typescript): Set no-unsafe-member-access severity to warn
d704072
@Hazmi35
fix(typescript): Allow constructor to have public accessibility modifier
8831deb
@Hazmi35
fix(typescript): Fix naming-convention options
99907e6 
I prefer it like this.
To be honest, I'm not sure, because there's probably some thing that needs to be named in snake_case or UPPER_CASE in the future, but I'll add it to the exception list later of course
@Hazmi35
Copy link
Owner Author

Hazmi35 commented Jan 13, 2022

Everything is done, only one thing to do: Test and recheck again

@Hazmi35 Hazmi35 merged commit e6de833 into main Jan 15, 2022
@Hazmi35 Hazmi35 deleted the feat/revamp branch January 15, 2022 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@hazmi35/eslint-config's first revamp
1 participant
@Hazmi35