Make shield service dynamic #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide a new variable for shield service name Rename some related shield variables to be more generic
|
Hey, @TwiterZX is this PR finished? |
|
Doesn’t seem to be finished.
First intention was to make badge less attached to shields.io because it was not working yesterday. As I didn’t find another service to rely on, I didn’t knew what kind of model to implement.
So I just made variable more generic, and introduced one for the service name to ease the work for improving.
I kept the dynamic word in the commit title because of the introduction of this variable😀.
Regards
|
|
Ok the commit title should be
Make shield service name dynamic.
…On 18 December 2017 at 19:51:28, Daniel Griesser ***@***.******@***.***)) wrote:
Hey, @TwiterZX(https://github.com/twiterzx) is this PR finished?
It's a nice abstraction but it's not really dynamic like in adding a command line parameter or something?!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub(#63 (comment)), or mute the thread(https://github.com/notifications/unsubscribe-auth/AAt5gOYyFUzZ9sr5HRGqNTXEWfabbbmDks5tBrQwgaJpZM4RFuGi).
|
|
Thx 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.