Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android 12 accuracy issue #62

Merged
merged 6 commits into from
Jan 20, 2022
Merged

Android 12 accuracy issue #62

merged 6 commits into from
Jan 20, 2022

Conversation

HarelM
Copy link
Collaborator

@HarelM HarelM commented Jan 19, 2022

Fixes #59

@HarelM
Copy link
Collaborator Author

HarelM commented Jan 19, 2022

@RaddishIoW let me know if you would like to review this.
Otherwise I'll merge and publish a new version.

@RaddishIoW
Copy link

If you're happy I am - only had a cursory look through but seems good.
Nice one.

@HarelM
Copy link
Collaborator Author

HarelM commented Jan 19, 2022

@RaddishIoW can we migrate out of the dev and main branch thing?
Last publishes I did were not successful or had issues due to this approach...

@RaddishIoW
Copy link

Yep - it's getting in the way and doesn't actually solve anything.
I think we'd just need to remove the GitHub actions relating to it? Then we can just merge the dev into main and be done with it?

@HarelM
Copy link
Collaborator Author

HarelM commented Jan 20, 2022

Ok, I'll work on it before the release.

@HarelM HarelM merged commit 1a17dcb into develop Jan 20, 2022
@HarelM HarelM deleted the 59-android-12-issue branch January 20, 2022 11:58
HarelM added a commit that referenced this pull request Jan 20, 2022
@HarelM
Android 12 accuracy issue (#62) (#63)
0169583 
* Move distance location provider

* Fix package name after movement

* Added logging for provider selection

* Hard code gps

* Fixes #59 - Use GPS provider on android 31.

* Fix hard coded parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HarelM @RaddishIoW