Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add include of mbedtls/platform.h to get SSL library to build on plat… #140

Merged
merged 1 commit into from
Jul 15, 2016

Conversation

ppenzin
Copy link
Collaborator

@ppenzin ppenzin commented Jul 14, 2016

…forms that have mbedtls_time_t type defined.

On Linux (at least in latest version) mbedtls is using time_t for the timestamps, while on some other platforms (BSD) it has a typedef mbedtls_type_t that is defined in mbedtls/platform.h

Including that header would not break anything for platform using time_t, but will enable building on the ones with mbedtls_time_t.

@andyli
Copy link
Member

andyli commented Jul 15, 2016

This is basically an issue of mbedtls and they have fixed it (see Mbed-TLS/mbedtls#522).
But since we can workaround it easily on our side too, I would go ahead and merge it such that we don't have to wait for a new mbedtls release :)

@andyli andyli merged commit 3599859 into HaxeFoundation:master Jul 15, 2016
@andyli
Copy link
Member

andyli commented Jul 15, 2016

@ppenzin btw, is Neko ready for the FreeBSD port now?

@ppenzin
Copy link
Collaborator Author

ppenzin commented Jul 15, 2016

Thanks! That version haven't made it to FreeBSD yet.

The code is ready, I am working on the actual port. There was a bunch of
stuff they brought up last time, but now most of it is fixed thanks to
the use of CMake.

I should probably add this to the issue:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204664

The only thing I don't have an answer for yet is mysql.h

On 07/14/16 22:57, Andy Li wrote:

@ppenzin https://github.com/ppenzin btw, is Neko ready for
theFreeBSD port now?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#140 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADMNddXISH0CAILp6G0oPbRIbb1VPhSVks5qVyE4gaJpZM4JM5NL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants