Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace setTimeout timeout: Int with : Float, fixes #8223 #8224

Merged
merged 2 commits into from
Apr 26, 2019

Conversation

haxiomic
Copy link
Member

@haxiomic haxiomic commented Apr 26, 2019

Replaces timeout: Int with timeout: Float in Window.setTimeout to fix issue #8223

I've fixed this in the generator but made the change manually because the generator is not yet caught
up with the js.lib changes.

Corresponding change in the generator
HaxeFoundation/html-externs@42023ac

closes #8223

@nadako
Copy link
Member

nadako commented Apr 26, 2019

Thanks! That was quick! Feel free to merge! \o/

@haxiomic haxiomic merged commit 9a714b9 into HaxeFoundation:development Apr 26, 2019
@skial skial mentioned this pull request May 1, 2019
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type definitions of Window.setTimeout and setInterval allow insidious errors [js]
2 participants