[ci] stay on node 18.17.1 for windows CI #11325
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our windows runners started using node
18.18.0
instead of18.17.1
last week, which led to TestUnicode failures:Tests output
Node 18.18.0 updates luv from 1.44.2 to 1.46.0 (nodejs/node#48078), which includes libuv/libuv#2970
that seems to be the reason of these failures:
Bad news is, since it's linked to a change in libuv, we'll continue having issues with these tests on windows in the future. We might have to change/disable the tests or try to make libuv maintainers avoid such errors (see the discussion in the PR comments).
For now we'll just dodge the issue to get our CI green again ©️