Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] stay on node 18.17.1 for windows CI #11325

Merged

Conversation

kLabz
Copy link
Contributor

@kLabz kLabz commented Oct 4, 2023

Our windows runners started using node 18.18.0 instead of 18.17.1 last week, which led to TestUnicode failures:

Tests output
TestUnicode
  testFilesystem: ERROR .............................................................................................................................................................FFFFFF.........FFFFFF.........FFFFFF.........FFFFFF...........................E
    line: 190, setCwd + absolutePath + endsWith failed (Only([65536]) in test-res)
    line: 190, setCwd + absolutePath + endsWith failed (Only([131071]) in test-res)
    line: 190, setCwd + absolutePath + endsWith failed (Only([1048575]) in test-res)
    line: 190, setCwd + absolutePath + endsWith failed (Only([1048576]) in test-res)
    line: 190, setCwd + absolutePath + endsWith failed (Only([1114111]) in test-res)
    line: 190, setCwd + absolutePath + endsWith failed (Only([128514,128516,128537]) in test-res)
    line: 212, expected exists == true (Only([65536]) in test-res/a)
    line: 212, expected exists == true (Only([131071]) in test-res/a)
    line: 212, expected exists == true (Only([1048575]) in test-res/a)
    line: 212, expected exists == true (Only([1048576]) in test-res/a)
    line: 212, expected exists == true (Only([1114111]) in test-res/a)
    line: 212, expected exists == true (Only([128514,128516,128537]) in test-res/a)
    line: 213, expected exists == false (Only([65536]) in test-res/b)
    line: 213, expected exists == false (Only([131071]) in test-res/b)
    line: 213, expected exists == false (Only([1048575]) in test-res/b)
    line: 213, expected exists == false (Only([1048576]) in test-res/b)
    line: 213, expected exists == false (Only([1114111]) in test-res/b)
    line: 213, expected exists == false (Only([128514,128516,128537]) in test-res/b)
    line: 231, expected isDirectory == true (Only([65536]) in test-res/a)
    line: 231, expected isDirectory == true (Only([131071]) in test-res/a)
    line: 231, expected isDirectory == true (Only([1048575]) in test-res/a)
    line: 231, expected isDirectory == true (Only([1048576]) in test-res/a)
    line: 231, expected isDirectory == true (Only([1114111]) in test-res/a)
    line: 231, expected isDirectory == true (Only([128514,128516,128537]) in test-res/a)
    Error: ENOENT: no such file or directory, stat 'test-res/a/𐀀'
Called from Object.statSync (node:fs line 1690 column 3)
Called from assertNormalEither.fileName (D:\a\haxe\haxe\tests\sys\bin\js\sys.js line 1866 column 22)
Called from TestUnicode.assertNormalEither (D:\a\haxe\haxe\tests\sys\bin\js\sys.js line 1644 column 11)
Called from TestUnicode.testFilesystem (D:\a\haxe\haxe\tests\sys\bin\js\sys.js line 1865 column 8)
Called from Object.execute (D:\a\haxe\haxe\tests\sys\bin\js\sys.js line 2005 column 11)
Called from utest_ITestHandler.runTest (D:\a\haxe\haxe\tests\sys\bin\js\sys.js line 5495 column 31)
Called from utest_ITestHandler.checkSetup (D:\a\haxe\haxe\tests\sys\bin\js\sys.js line 5490 column 9)
Called from utest_Async.then (D:\a\haxe\haxe\tests\sys\bin\js\sys.js line 5082 column 4)
Called from utest_ITestHandler.runSetup (D:\a\haxe\haxe\tests\sys\bin\js\sys.js line 5483 column 19)
Called from utest_ITestHandler.execute (D:\a\haxe\haxe\tests\sys\bin\js\sys.js line 5471 column 8)
  testIO: ERROR ........E
    Error: ENOENT: no such file or directory, open 'test-res/b/𐀀'
Called from Object.openSync (node:fs line 603 column 3)
Called from Object.readFileSync (node:fs line 471 column 35)
Called from module at D:\a\haxe\haxe\tests\sys\bin\js\sys.js:1936:84
Called from TestUnicode.pathBoth (D:\a\haxe\haxe\tests\sys\bin\js\sys.js line 1613 column 5)
Called from TestUnicode.testIO (D:\a\haxe\haxe\tests\sys\bin\js\sys.js line 1935 column 8)
Called from Object.execute (D:\a\haxe\haxe\tests\sys\bin\js\sys.js line 2001 column 11)
Called from utest_ITestHandler.runTest (D:\a\haxe\haxe\tests\sys\bin\js\sys.js line 5495 column 31)
Called from utest_ITestHandler.checkSetup (D:\a\haxe\haxe\tests\sys\bin\js\sys.js line 5490 column 9)
Called from utest_Async.then (D:\a\haxe\haxe\tests\sys\bin\js\sys.js line 5082 column 4)
Called from utest_ITestHandler.runSetup (D:\a\haxe\haxe\tests\sys\bin\js\sys.js line 5483 column 19)

Node 18.18.0 updates luv from 1.44.2 to 1.46.0 (nodejs/node#48078), which includes libuv/libuv#2970
that seems to be the reason of these failures:

fs: use WTF-8 on Windows

Bad news is, since it's linked to a change in libuv, we'll continue having issues with these tests on windows in the future. We might have to change/disable the tests or try to make libuv maintainers avoid such errors (see the discussion in the PR comments).

For now we'll just dodge the issue to get our CI green again ©️

@kLabz kLabz merged commit 00da367 into HaxeFoundation:development Oct 4, 2023
49 checks passed
0b1kn00b pushed a commit to 0b1kn00b/haxe that referenced this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant