Update for extlib 1.7.8 breaking change #10086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kLabz
force-pushed
the
update/extlib-1.7.8
branch
from
6d9d7e4 to
2a66250
Compare
See https://github.com/ygrek/ocaml-extlib/releases/tag/1.7.8 > breaking change: ExtList.find_map type updated to match stdlib (following deprecation in previous release)
Copied from: https://github.com/ygrek/ocaml-extlib/blob/f30acba5bb1e092faf22f777cef1b72a7b109097/src/base64.ml https://github.com/ygrek/ocaml-extlib/blob/f30acba5bb1e092faf22f777cef1b72a7b109097/src/base64.mli See conflict introduced by this change in ocaml-base64: mirage/ocaml-base64#25
kLabz
force-pushed
the
update/extlib-1.7.8
branch
from
2a66250 to
e68bec4
Compare
|
Might be better to skip squash for this PR to keep commit messages for context? |
kLabz
changed the title
|
Macro tests failure not related (see d764121) |
| @@ -33,6 +33,7 @@ open EvalHash | |||
| open EvalEncode | |||
| open EvalField | |||
| open MacroApi | |||
| open Extlib_leftovers | |||
andyli
added a commit
to HaxeFoundation/docker-library-haxe
that referenced
this pull request
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: we need to update our local opam environment for this
From extlib 1.7.8 release notes:
(our CI is using 1.7.8 while most of us are still using <=1.7.7 locally)
Also included base64 to extlib-leftovers, possibly needed because of mirage/ocaml-base64#25