Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Documentation pages, and REMOVE DOCPAD #247

Merged
merged 16 commits into from
Mar 4, 2024

Conversation

ninjamuffin99
Copy link
Member

@ninjamuffin99 ninjamuffin99 commented Mar 2, 2024

I will let @Geokureli do the honors of merging this.

  • Does a buncho configs for prettier, standardjs, and liquid for basic tests / linting / formatting
  • Ports the /documentation pages to 11ty
  • Removes most of the docpad related code. Site is fully built with 11ty for it's static site generation
  • Likely more stuff but i forget!

There's still some things needed to be done before a new site publish, but this is one of the last BIG pieces!

Stuff left on the todo: #223

@Geokureli
Copy link
Member

Mfkr it's Friday, i ain't merging shit

@ninjamuffin99
Copy link
Member Author

omfg im so sad i might just close this pr...

@Geokureli
Copy link
Member

do i preview these changes via dev.haxeflixel or on that ninjamuffin.github link?

@ninjamuffin99
Copy link
Member Author

ninjamuffin99 commented Mar 4, 2024 via email

@ninjamuffin99
Copy link
Member Author

do i preview these changes via dev.haxeflixel or on that ninjamuffin.github link?

you can preview the site at https://ninjamuffin99.github.io/haxeflixel.com !

this is now also setup where forks can easily build to their own github.io page, without having effect on the dev/master stuff here :)

@Geokureli
Copy link
Member

I notice the tutorial code shows up in an less pleasant way:
Screenshot 2024-03-04 at 2 53 17 PM

compared to the current version:
Screenshot 2024-03-04 at 2 55 50 PM

@ninjamuffin99
Copy link
Member Author

ninjamuffin99 commented Mar 4, 2024

yeah right now thats still on the todo! this PR is just for the documentation pages in general being ported, getting the highlighting looking nice again is one of the last things on the current todo!

related issue #245

link to the todo list tracker for the site to be "ready":tm: #223

@Geokureli
Copy link
Member

what is the timeline, here? we wanna merge this and then finish the other tasks before publishing the new version? I wonder if it makes more sense to continue using a branch for these changes until they are ready to be published, that way we can add all those new blog posts that I'm too lazy to get around to. jk but, realistically, how long between this merge and when we can publish the new version?

@ninjamuffin99
Copy link
Member Author

Likely this week! It would take maybe a "session" or two of me working on it to hopefully get it READY for final site publish and update. I think pushing things into dev branch would also be good and nice for testing around to people, making sure that everything works on site itself and no snafus occur.
In any case, I do think this one is definitely merge ready, and then within the next few days I'll be able to finish up the remaining tasks to have the site in near perfect parity from the old site

@Geokureli
Copy link
Member

okay, just wanted to make sure it wasn't gonna be a month more

@Geokureli Geokureli merged commit 722a288 into HaxeFlixel:dev Mar 4, 2024
5 checks passed
@Geokureli
Copy link
Member

yolo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants