Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to HaxeFlixel/flixel-demos#281
To Summarize:
FlxGraphic.fromClass(GraphicAuto)
results in a BitmapData of size 0x0 while it fetches the data asynchronously. When passed into a tilemap, no actual visible or solid tiles are created, this is why the EZPlatformer and SplitScreen demos don't work.This change allows the autotile tilemaps to be used via
"flixel/images/tile/autotiles.png"
. I plan to update the demos to do this if this is approved.There may be other ways to fix this so people can use flixel's default autotile tilemaps. I don't know if there's some event that our demos could listen for before using the images, but I'd rather these demos avoid async listeners and look extremely simple to newcomers looking for snippets.
I don't know what effect this has on the export's file size to embed these images in every project. I assume they are already embedded via:
@:keep @:bitmap
. does this mean they are embedded twice? should we deprecate the@:bitmap
classes?