Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlxEmitter: add maxSize = Quantity to makeParticles() #2265

Merged
merged 1 commit into from
Jul 23, 2020

Conversation

dean1010
Copy link
Contributor

I think this was an oversight.

@dean1010
Copy link
Contributor Author

If you create an emitter using

makeParticles(2, 2, 0xFFFFFFFF, 10);

and emit more than 10 at one time, it will create a new particle with the HaxeFlixel logo, rather than recycling the 2 x 2 particles.

@Gama11
Copy link
Member

Gama11 commented Jul 23, 2020

Seems like it's an oversight indeed: https://github.com/AdamAtomic/flixel/blob/8989e5044be072c4abbbaa1317c9854786f6447f/org/flixel/FlxEmitter.as#L164

Earlier versions of HaxeFlixel had it too, it just seems to have gotten lost after some refactors.

@Gama11 Gama11 changed the title Added maxSize = Quantity to makeParticles() FlxEmitter: add maxSize = Quantity to makeParticles() Jul 23, 2020
@Gama11 Gama11 merged commit 356231e into HaxeFlixel:dev Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants