Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FlxSpriteUtil.alphaMask() should use FlxGraphicAsset #1806

Closed
Gama11 opened this issue Apr 6, 2016 · 3 comments
Closed

FlxSpriteUtil.alphaMask() should use FlxGraphicAsset #1806

Gama11 opened this issue Apr 6, 2016 · 3 comments

Comments

@Gama11
Copy link
Member

Gama11 commented Apr 6, 2016

Currently uses Dynamic and implements the type checking itself instead of using FlxAssets.resolveBitmapData() .
@buckle2000
Copy link
Contributor

We can declare FlxGraphicAsset as abtract type of OneOfThree<...>, and then add @:to toBitmapData or something. So we can do implicit cast on the go.
Is that practicable?

@Gama11
Copy link
Member Author

Gama11 commented Apr 12, 2016

Not sure why the @:to toBitmapData would be necessary here?

@buckle2000
Copy link
Contributor

Never mind. I think it would just be a more natural way, since if someone want to convert FlxGraphicAsset to BitmapData, one may never check FlxAssets.

Beeblerox added a commit that referenced this issue Apr 16, 2016
@Beeblerox
fix for issue #1806
65afb7e
@Gama11 Gama11 closed this as completed Apr 16, 2016
Aurel300 pushed a commit to larsiusprime/haxeflixel that referenced this issue Apr 18, 2018
@Beeblerox @Aurel300
fix for issue HaxeFlixel#1806
6bcbf37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Gama11 @buckle2000