Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown Editor & Preview respect outer container & responsive; #443

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

wtfsayo
Copy link
Contributor

@wtfsayo wtfsayo commented Nov 6, 2023

GitHub Issue

#440

Changes

  1. Added a ContentWrapper around the Dialog Content
  2. DialogMarkdown Editor & Preview mode now respect that outer content
  3. ContentWrapper utilises viewport width to be responsive

Screenshot 2023-11-06 at 5 43 31 PM
Screenshot 2023-11-06 at 5 44 07 PM
Screenshot 2023-11-06 at 5 44 12 PM

Packages Added

none

Checks

Before making your PR, please check the following:

  • Critical lint errors are resolved
  • App runs locally
  • App builds locally (run the build command for any impacted package and check for any errors before the PR)

@dekanbro
Copy link
Contributor

dekanbro commented Nov 6, 2023

This looks like a great solution. We may be able to get a little wider on mobile using one of these

isMobile hook:
https://github.com/HausDAO/monorepo/blob/develop/libs/ui/README.md?plain=1#L79

media queries with theme breakpoints
https://github.com/HausDAO/monorepo/blob/develop/apps/dev-sandbox/src/components/HomeContent.tsx#L37

@wtfsayo
Copy link
Contributor Author

wtfsayo commented Nov 6, 2023

Thanks for your comments @dekanbro

however there is an issue to achieve better responsiveness on mobile:

Without changing DialogContent max-width it may require a lot of workaround

@dekanbro
Copy link
Contributor

dekanbro commented Nov 7, 2023

New Issue to track convo around Dialog theme #447

@dekanbro dekanbro merged commit 5f26d56 into HausDAO:develop Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants