-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Safe Pages to display basic token balances - NEEDS NEW DATA SOURCE #507
Labels
Comments
dekanbro
added a commit
that referenced
this issue
May 21, 2024
Fix/remove safe api usd balances. see #507
dekanbro
changed the title
White screen on Vault and ragequit pages pages due to deprecated USD endpoint on Safe API
White screen on Vault and ragequit pages due to deprecated USD endpoint on Safe API
May 21, 2024
We use the Safe transaction api in a few different places. notes:
it will be hard to fully remove the dependencies here unless we find a better way to get balances of a Safe address. To do this on chain seems like we would need a way to register token addresses for a specific Safe like in a DAO watchlist |
skuhlmann
changed the title
White screen on Vault and ragequit pages due to deprecated USD endpoint on Safe API
Update Safe Pages to display basic token balances - NEEDS NEW DATA SOURCE
Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Feature
Vault page on Safe UI
App
Expected Behavior
Should display value of tokens in USD per the Safe API data
Actual Behavior
It fails violently and crashes the app.
Steps to Reproduce
Go to the Safe Vault page
Browser
No response
Screenshots and Context
This PR is a temporary fix and removes calls to the Safe api. We should lookinto a new solution for this UI. Probably remove the dependency on a third party api and think of a better why to display all balances of tokens in the treasury without current USD value. #506 (comment)
The text was updated successfully, but these errors were encountered: