Add OpenGSN support to Baal #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshaan
commented
Sep 21, 2022
|
On your note about using the params struct, we should not need it now. I was able to remove the name and symbol because they are being set in the summoner now |
akshaan
changed the base branch from
feat/baalZodiac
to
feat/refac-token-pausable
brossetti1
approved these changes
Sep 22, 2022
There was a problem hiding this comment.
if the build succeeds and the tests pass, this looks good to me, nice @akshaan !
dekanbro
approved these changes
Sep 22, 2022
dekanbro
added a commit
that referenced
this pull request
Sep 22, 2022
* move pausable function to token, todo: test failes on minting when paused * clean up console logs * remove pausable modifier for custom logic * update loot token tests * add comments * fix syntax typo * remove name and symbol from destructing * address review, fix if else logic, remove pause vailibles because they are in the token now * Add OpenGSN support to Baal (#73) * Add OpenGSN support to Baal * Add tests * Add docstrings * Drop hardhat configs for large contracts * Use init params to pass in forwarder * Clean up tests Co-authored-by: dekanbro <[email protected]> Co-authored-by: Akshaan Kakar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for OpenGSN-style meta-transactions (EIP-2771) to Baal contract functions