Add upgradable tokens and proxy #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brossetti1
commented
Sep 15, 2022
contracts/Baal.sol
Outdated
Comment on lines
261
to
264
| IBaalToken(_lootSingleton).setUp.selector, | ||
| string(abi.encodePacked(_name, " LOOT")), | ||
| string(abi.encodePacked(_symbol, "-LOOT"))) | ||
| ))); |
There was a problem hiding this comment.
wondering about this part here -- we did add dynamic names in the setup of the LootTokens
https://github.com/HausDAO/Baal/blob/feat/baalZodiac/contracts/LootERC20.sol#L29-L33
i know these are templates but would it make more sense to also pass the _name/_symbol here?
test/BaalSafe.test.ts
Outdated
| @@ -489,7 +492,7 @@ describe("Baal contract", function () { | |||
| }); | |||
|
|
|||
| describe("constructor", function () { | |||
| it("verify deployment parameters", async function () { | |||
| it.only("verify deployment parameters", async function () { | |||
There was a problem hiding this comment.
going to want to remove this
dekanbro
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dekan - adds proxies