Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/erc20 permit upgradeable #62

Merged
merged 7 commits into from
Sep 13, 2022
Merged

Feat/erc20 permit upgradeable #62

merged 7 commits into from
Sep 13, 2022

Conversation

brossetti1
Copy link

adding Upgradeable contracts - this allows us to:

  • init the 712 signatures with the dynamic token name in the DOMAIN_SEPERATOR
  • remove overrides on __name and __symbol and name() and symbol() for our Loot and Shares token and inherit these from OZ
  • adding additional slither findings
  • removing unused OZ contracts

@brossetti1 brossetti1 requested a review from dekanbro August 25, 2022 22:22
@brossetti1 brossetti1 force-pushed the feat/erc20PermitUpgradeable branch from 6381433 to 62344b7 Compare August 25, 2022 22:24
@brossetti1 brossetti1 force-pushed the feat/erc20PermitUpgradeable branch from 62344b7 to 47f553c Compare September 13, 2022 20:43
@dekanbro dekanbro merged commit 54c75b5 into feat/baalZodiac Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dekanbro dekanbro dekanbro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brossetti1 @dekanbro