restore dayjs timezone tests #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyacheslav-pushkin
requested changes
Jul 19, 2021
| @@ -3,6 +3,8 @@ import dayjs from 'dayjs'; | |||
| import customParseFormat from 'dayjs/plugin/customParseFormat'; | |||
| import MockDate from 'mockdate'; | |||
|
|
|||
| const systemTimeZone = dayjs().format('Z'); | |||
There was a problem hiding this comment.
Can we mock the timezone instead (set dayjs to use a certain predetermined timezone in the tests)?
This can make the tests more robust / independent from environment.
There was a problem hiding this comment.
I tried 3 ways, none of them worked:
- With package for mock timezone. It conflicts with the other package
mockdate. - Redefine
dayjspackage for jest with dayjs's method.tz().dayjs()anddayjs.tz()work in different ways. - Set default timezone for jest with TZ env. variable. The problem is, that it doesn't work for windows. I can't set a default timezone on windows. nodejs/node#4230
There was a problem hiding this comment.
OK, let's leave it as it is for now.
vyacheslav-pushkin
approved these changes
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.