Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add on chain blueprint class, its serialization, and a method to create the tx from the wallet #811

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

pedroferreira1
Copy link
Member

@pedroferreira1 pedroferreira1 commented Jan 16, 2025

Acceptance Criteria

  • Create On Chain Blueprint class with object serialization methods.
  • Create method in the wallet facade to create an ocb transaction.
  • Add integration tests for creating and executing nano contract methods from an ocb.

Note: the integration tests will only succeed after we release a new docker image for tx mining service and hathor core with ocb support (and update the docker-compose with them).

@pedroferreira1 pedroferreira1 changed the title feat: add on chain blueprint class, its serialization, and a method t… feat: add on chain blueprint class, its serialization, and a method to create the tx from the wallet Jan 16, 2025
@pedroferreira1 pedroferreira1 self-assigned this Jan 16, 2025
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 7.27273% with 51 lines in your changes missing coverage. Please review.

Project coverage is 66.66%. Comparing base (c184bbd) to head (b564de9).

Files with missing lines Patch % Lines
src/nano_contracts/on_chain_blueprint.ts 0.00% 32 Missing ⚠️
src/new/wallet.js 0.00% 13 Missing and 4 partials ⚠️
src/utils/transaction.ts 50.00% 2 Missing ⚠️

❌ Your patch check has failed because the patch coverage (7.27%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project check has failed because the head coverage (66.66%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (c184bbd) and HEAD (b564de9). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (c184bbd) HEAD (b564de9)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #811       +/-   ##
===========================================
- Coverage   80.77%   66.66%   -14.11%     
===========================================
  Files          86       87        +1     
  Lines        6594     6645       +51     
  Branches     1420     1436       +16     
===========================================
- Hits         5326     4430      -896     
- Misses       1255     2130      +875     
- Partials       13       85       +72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pedroferreira1 pedroferreira1 marked this pull request as ready for review January 29, 2025 15:46
@pedroferreira1 pedroferreira1 force-pushed the feat/on-chain-blueprint branch from 5d9a235 to c86ac88 Compare January 29, 2025 15:54
@pedroferreira1 pedroferreira1 requested review from tuliomir and r4mmer and removed request for tuliomir February 3, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review (WIP)
Development

Successfully merging this pull request may close these issues.

2 participants