Adding matrix multiplication. #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding matrix-matrix, vector-matrix, and matrix-vector support to `*` for the ExtOpenScad interface, and to `mult` for the haskell interface. Adding tests based on matrix multiplication tutorials I found online and results from WolframAlpha. This addresses Haskell-Things#414
It built locally without this type, so maybe we should look into what is different between the local cabal file and what settings the build boxes are using.
julialongtin
approved these changes
Nov 19, 2022
| @@ -13,7 +13,8 @@ | |||
| module Graphics.Implicit.ExtOpenScad.Default (defaultObjects) where | |||
|
|
|||
| -- be explicit about where we pull things in from. | |||
| import Prelude (Bool(True, False), Maybe(Just, Nothing), ($), (<>), (<$>), fmap, pi, sin, cos, tan, asin, acos, atan, sinh, cosh, tanh, abs, signum, fromInteger, (.), floor, ceiling, round, exp, log, sqrt, max, min, atan2, (**), flip, (<), (>), (<=), (>=), (==), (/=), (&&), (||), not, show, foldl, (*), (/), mod, (+), zipWith, (-), otherwise, id, foldMap, fromIntegral, IO, pure) | |||
| import Prelude (Bool(True, False), Maybe(Just, Nothing), ($), (<>), (<$>), fmap, pi, sin, cos, tan, asin, acos, atan, sinh, cosh, tanh, abs, signum, fromInteger, (.), floor, ceiling, round, exp, log, sqrt, max, min, atan2, (**), flip, (<), (>), (<=), (>=), (==), (/=), (&&), (||), not, show, foldl, (*), (/), mod, (+), zipWith, (-), otherwise, id, foldMap, fromIntegral, IO, pure, Int) | |||
| import qualified Prelude as P | |||
There was a problem hiding this comment.
all of prelude? i like knowing what i'm pulling in.
There was a problem hiding this comment.
Ah yep, fixed. I'm used to either unqualified imports with explicit lists, or qualified imports without lists and forgot that you could combine them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding matrix-matrix, vector-matrix, and matrix-vector support to
*for the ExtOpenScad interface, and tomultfor the haskell interface.Adding tests based on matrix multiplication tutorials I found online and results from WolframAlpha.
This addresses #414