Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the broken triangle generation #355

Merged
merged 3 commits into from
Dec 17, 2020
Merged

Fix the broken triangle generation #355

merged 3 commits into from
Dec 17, 2020

Conversation

isovector
Copy link
Contributor

@isovector isovector commented Dec 16, 2020

This fixes the broken triangles. Detailing was attempting to do... something... and it didn't work.

All of the changed golden tests pass my eyeball test.

Fixes #353

@isovector
Copy link
Contributor Author

isovector commented Dec 16, 2020

When trying to reproduce #280, I stumbled across this:

writeSTL 3 "/tmp/yo.stl"  $ implicit (\(V3 x y z) -> x^4 + y^4 + z^4
 - 15000) (pure (-20),pure 20) <> (translate (pure 20) $ cubeR 0 True (pure 15)) 

which before this patch looks like this:

2020-12-16-135014_598x260_scrot

and now looks like:

2020-12-16-135616_416x220_scrot

@isovector isovector mentioned this pull request Dec 16, 2020
@isovector isovector marked this pull request as ready for review December 16, 2020 22:02
@julialongtin julialongtin merged commit 2218fc4 into Haskell-Things:master Dec 17, 2020
@isovector isovector deleted the fix-triangles branch December 29, 2020 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tesselation is broken
2 participants