Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Added]: Image Request Feature #1303

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

AlapanDas
Copy link

@AlapanDas AlapanDas commented Mar 2, 2022

Description

This feature will fetch Images with user-defined tags from the public image library (hence usable for creative purposes ) , it will also provide the user with image quality control such as HD,FHD,2K,4K..etc

Fixes #1294

Replace issue_no with the issue number which is fixed in this PR

Type of change

  • New feature (non-breaking change which adds functionality)
  • [ ]
    This script asks the user about the choice of selection from the avaliable catalogue of images. After providing the respective choices , it will send request to the Photo API system for fetching the images and in case of desired user keywords ,again asks the user about the keywords seperated by commas ( the commas will be cleared out using replace function)
    and then fetch the images having similar keywords. The image will be displayed in default photo viewer of that OS.

Checklist:

  • My code follows the style guidelines(Clean Code) of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests/screenshots(if any) that prove my fix is effective or that my feature works
    Screenshots-
    image
    Random Image Generation
    image
    Topic based Image Generation

@ghost
Copy link

ghost commented Mar 2, 2022

CodeSee Review Map:

Review these changes using an interactive CodeSee Map

Review in an interactive map

View more CodeSee Maps

Legend

CodeSee Map Legend

import requests
from PIL import Image
def img_requests(txt):
response=requests.get("https://source.unsplash.com/random/{0}".format(txt))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add more image sources, if that's possible?

Copy link
Author

@AlapanDas AlapanDas Mar 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah i think some I can add but , those will need an email id for api key and most of them are paid. I choose unsplash because it is free and requires no api key or authentication as such and the most imp point it is very user friendly.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a GSSOC Level in this PR

from PIL import Image
def img_requests(txt):
response=requests.get("https://source.unsplash.com/random/{0}".format(txt))
file=open('sample_image.jpg','wb')
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid using ambiguous filenames.

@AlapanDas AlapanDas requested a review from HarshCasper March 4, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request]:Image Request
2 participants