Improve monorepo support so it requires less manual configuration #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriszyp
reviewed
Nov 23, 2024
There was a problem hiding this comment.
If I understand correctly, the underlying assumption here is that the component path points to the specific app within the repo that should be run. However, this seems problematic for deployment. I would assume that the whole monorepo needs to be deployed to any HDB server that will be hosting/serving even one app, so any shared sub-repos are accessible. Perhaps an improved monorepo experience would be supporting an indication of which folder(s) of the app within a monorepo that should be started as a next app?
Or alternately is there an improved experience in using the pre-built app?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, monorepo support required some configuration workarounds.
With this PR, the configuration is streamlined and it is easier to deploy a Next.js app within a monorepo to HarperDB
Tested manually with both Nx and Turbo