Skip to content

Commit

Permalink
[Azure Maps] Geolocation: swagger improvement for SDK generation [Hub…
Browse files Browse the repository at this point in the history
… Generated] (Azure#16030)

* Geolocation: Use user-friendly key and filename for x-ms-examples

* Geolocation: Use client name ipAddress for parameter ip

* Common: Set TextFormat/ResponseFormat default to json

* All: Remove operationId prefix for swagger except Creator

* Geolocation: Rename method GetIPToLocationPreview to GetLocation

* All: Rename [Service]ApiVersion to ApiVersion

* Common: Use client name mapsClientId for x-ms-client-id

* Remove -Preview suffix

* Common: Remove x-ms-parameterized-host/schemes/cosumes

* Common: TextFormat->ResponseFormat, ResponseFormat->JsonFormat

* Common: Model GeojsonObject as a closed enum

* Common: Reset JsonFormat/ResponseFormat modelAsString=true

* Common: Rename mapsClientId as clientId
  • Loading branch information
alankashiwa authored and Milan Zolota committed Sep 27, 2021
1 parent 99e632d commit 0fe4385
Show file tree
Hide file tree
Showing 20 changed files with 266 additions and 274 deletions.
25 changes: 8 additions & 17 deletions specification/maps/data-plane/Common/preview/1.0/common.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,6 @@
"title": "Azure Maps Common Types",
"version": "1.0"
},
"x-ms-parameterized-host": {
"hostTemplate": "{geography}.atlas.microsoft.com",
"parameters": [
{
"$ref": "#/parameters/GeographicResourceLocation"
}
]
},
"schemes": [
"https"
],
"consumes": [],
"produces": [
"application/json"
],
Expand Down Expand Up @@ -203,7 +191,7 @@
],
"x-ms-enum": {
"name": "GeoJsonObjectType",
"modelAsString": true,
"modelAsString": false,
"values": [
{
"value": "Point",
Expand Down Expand Up @@ -535,6 +523,7 @@
"parameters": {
"ClientId": {
"name": "x-ms-client-id",
"x-ms-client-name": "clientId",
"description": "Specifies which account is intended for usage in conjunction with the Azure AD security model. It represents a unique ID for the Azure Maps account and can be retrieved from the Azure Maps management plane Account API. To use Azure AD security in Azure Maps see the following [articles](https://aka.ms/amauthdetails) for guidance.",
"type": "string",
"in": "header",
Expand All @@ -547,7 +536,7 @@
"type": "string",
"x-ms-parameter-location": "method"
},
"ResponseFormat": {
"JsonFormat": {
"name": "format",
"description": "Desired format of the response. Only `json` format is supported.",
"type": "string",
Expand All @@ -557,7 +546,7 @@
"json"
],
"x-ms-enum": {
"name": "ResponseFormat",
"name": "JsonFormat",
"modelAsString": true,
"values": [
{
Expand All @@ -566,9 +555,10 @@
}
]
},
"x-ms-client-default": "json",
"x-ms-parameter-location": "method"
},
"TextFormat": {
"ResponseFormat": {
"name": "format",
"description": "Desired format of the response. Value can be either _json_ or _xml_.",
"type": "string",
Expand All @@ -579,7 +569,7 @@
"xml"
],
"x-ms-enum": {
"name": "TextFormat",
"name": "ResponseFormat",
"modelAsString": true,
"values": [
{
Expand All @@ -592,6 +582,7 @@
}
]
},
"x-ms-client-default": "json",
"x-ms-parameter-location": "method"
},
"GeographicResourceLocation": {
Expand Down
38 changes: 19 additions & 19 deletions specification/maps/data-plane/Creator/preview/1.0/spatial.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
],
"responses": {},
"parameters": {
"SpatialApiVersion": {
"ApiVersion": {
"name": "api-version",
"description": "Version number of Azure Maps API.",
"type": "string",
Expand Down Expand Up @@ -176,10 +176,10 @@
"$ref": "../../../Common/preview/1.0/common.json#/parameters/ClientId"
},
{
"$ref": "#/parameters/SpatialApiVersion"
"$ref": "#/parameters/ApiVersion"
},
{
"$ref": "../../../Common/preview/1.0/common.json#/parameters/ResponseFormat"
"$ref": "../../../Common/preview/1.0/common.json#/parameters/JsonFormat"
},
{
"name": "deviceId",
Expand Down Expand Up @@ -263,10 +263,10 @@
"$ref": "../../../Common/preview/1.0/common.json#/parameters/ClientId"
},
{
"$ref": "#/parameters/SpatialApiVersion"
"$ref": "#/parameters/ApiVersion"
},
{
"$ref": "../../../Common/preview/1.0/common.json#/parameters/ResponseFormat"
"$ref": "../../../Common/preview/1.0/common.json#/parameters/JsonFormat"
},
{
"name": "deviceId",
Expand Down Expand Up @@ -348,10 +348,10 @@
"$ref": "../../../Common/preview/1.0/common.json#/parameters/ClientId"
},
{
"$ref": "#/parameters/SpatialApiVersion"
"$ref": "#/parameters/ApiVersion"
},
{
"$ref": "../../../Common/preview/1.0/common.json#/parameters/ResponseFormat"
"$ref": "../../../Common/preview/1.0/common.json#/parameters/JsonFormat"
},
{
"name": "bufferRequestBody",
Expand Down Expand Up @@ -388,10 +388,10 @@
"$ref": "../../../Common/preview/1.0/common.json#/parameters/ClientId"
},
{
"$ref": "#/parameters/SpatialApiVersion"
"$ref": "#/parameters/ApiVersion"
},
{
"$ref": "../../../Common/preview/1.0/common.json#/parameters/ResponseFormat"
"$ref": "../../../Common/preview/1.0/common.json#/parameters/JsonFormat"
},
{
"$ref": "#/parameters/SpatialUploadUdid"
Expand Down Expand Up @@ -431,10 +431,10 @@
"$ref": "../../../Common/preview/1.0/common.json#/parameters/ClientId"
},
{
"$ref": "#/parameters/SpatialApiVersion"
"$ref": "#/parameters/ApiVersion"
},
{
"$ref": "../../../Common/preview/1.0/common.json#/parameters/ResponseFormat"
"$ref": "../../../Common/preview/1.0/common.json#/parameters/JsonFormat"
},
{
"$ref": "#/parameters/SpatialLatitude"
Expand Down Expand Up @@ -477,10 +477,10 @@
"$ref": "../../../Common/preview/1.0/common.json#/parameters/ClientId"
},
{
"$ref": "#/parameters/SpatialApiVersion"
"$ref": "#/parameters/ApiVersion"
},
{
"$ref": "../../../Common/preview/1.0/common.json#/parameters/ResponseFormat"
"$ref": "../../../Common/preview/1.0/common.json#/parameters/JsonFormat"
},
{
"$ref": "#/parameters/SpatialUploadUdid"
Expand Down Expand Up @@ -525,10 +525,10 @@
"$ref": "../../../Common/preview/1.0/common.json#/parameters/ClientId"
},
{
"$ref": "#/parameters/SpatialApiVersion"
"$ref": "#/parameters/ApiVersion"
},
{
"$ref": "../../../Common/preview/1.0/common.json#/parameters/ResponseFormat"
"$ref": "../../../Common/preview/1.0/common.json#/parameters/JsonFormat"
},
{
"$ref": "#/parameters/SpatialLatitude"
Expand Down Expand Up @@ -565,10 +565,10 @@
"$ref": "../../../Common/preview/1.0/common.json#/parameters/ClientId"
},
{
"$ref": "#/parameters/SpatialApiVersion"
"$ref": "#/parameters/ApiVersion"
},
{
"$ref": "../../../Common/preview/1.0/common.json#/parameters/ResponseFormat"
"$ref": "../../../Common/preview/1.0/common.json#/parameters/JsonFormat"
},
{
"$ref": "#/parameters/SpatialUploadUdid"
Expand Down Expand Up @@ -607,10 +607,10 @@
"$ref": "../../../Common/preview/1.0/common.json#/parameters/ClientId"
},
{
"$ref": "#/parameters/SpatialApiVersion"
"$ref": "#/parameters/ApiVersion"
},
{
"$ref": "../../../Common/preview/1.0/common.json#/parameters/ResponseFormat"
"$ref": "../../../Common/preview/1.0/common.json#/parameters/JsonFormat"
},
{
"name": "query",
Expand Down
12 changes: 6 additions & 6 deletions specification/maps/data-plane/Creator/preview/2.0/alias.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
],
"responses": {},
"parameters": {
"AliasApiVersionV2": {
"ApiVersion": {
"name": "api-version",
"description": "Version number of Azure Maps API.",
"type": "string",
Expand Down Expand Up @@ -97,7 +97,7 @@
"$ref": "../../../Common/preview/1.0/common.json#/parameters/ClientId"
},
{
"$ref": "#/parameters/AliasApiVersionV2"
"$ref": "#/parameters/ApiVersion"
},
{
"$ref": "#/parameters/CreateCreatorDataItemId"
Expand Down Expand Up @@ -134,7 +134,7 @@
"$ref": "../../../Common/preview/1.0/common.json#/parameters/ClientId"
},
{
"$ref": "#/parameters/AliasApiVersionV2"
"$ref": "#/parameters/ApiVersion"
}
],
"x-ms-pageable": {
Expand Down Expand Up @@ -171,7 +171,7 @@
"$ref": "#/parameters/AliasId"
},
{
"$ref": "#/parameters/AliasApiVersionV2"
"$ref": "#/parameters/ApiVersion"
},
{
"$ref": "#/parameters/AssignCreatorDataItemId"
Expand Down Expand Up @@ -205,7 +205,7 @@
"$ref": "#/parameters/AliasId"
},
{
"$ref": "#/parameters/AliasApiVersionV2"
"$ref": "#/parameters/ApiVersion"
}
],
"responses": {
Expand Down Expand Up @@ -233,7 +233,7 @@
"$ref": "#/parameters/AliasId"
},
{
"$ref": "#/parameters/AliasApiVersionV2"
"$ref": "#/parameters/ApiVersion"
}
],
"responses": {
Expand Down
14 changes: 7 additions & 7 deletions specification/maps/data-plane/Creator/preview/2.0/data.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
],
"responses": {},
"parameters": {
"DataApiVersionV2": {
"ApiVersion": {
"name": "api-version",
"description": "Version number of Azure Maps API.",
"type": "string",
Expand Down Expand Up @@ -139,7 +139,7 @@
"$ref": "../../../Common/preview/1.0/common.json#/parameters/ClientId"
},
{
"$ref": "#/parameters/DataApiVersionV2"
"$ref": "#/parameters/ApiVersion"
},
{
"$ref": "#/parameters/UploadDataDescription"
Expand Down Expand Up @@ -185,7 +185,7 @@
"$ref": "../../../Common/preview/1.0/common.json#/parameters/ClientId"
},
{
"$ref": "#/parameters/DataApiVersionV2"
"$ref": "#/parameters/ApiVersion"
}
],
"responses": {
Expand Down Expand Up @@ -219,7 +219,7 @@
"$ref": "../../../Common/preview/1.0/common.json#/parameters/ClientId"
},
{
"$ref": "#/parameters/DataApiVersionV2"
"$ref": "#/parameters/ApiVersion"
},
{
"$ref": "#/parameters/UniqueDataId"
Expand Down Expand Up @@ -270,7 +270,7 @@
"$ref": "../../../Common/preview/1.0/common.json#/parameters/ClientId"
},
{
"$ref": "#/parameters/DataApiVersionV2"
"$ref": "#/parameters/ApiVersion"
},
{
"$ref": "#/parameters/UniqueDataId"
Expand Down Expand Up @@ -307,7 +307,7 @@
"$ref": "../../../Common/preview/1.0/common.json#/parameters/ClientId"
},
{
"$ref": "#/parameters/DataApiVersionV2"
"$ref": "#/parameters/ApiVersion"
},
{
"$ref": "#/parameters/UniqueDataId"
Expand Down Expand Up @@ -337,7 +337,7 @@
},
"parameters": [
{
"$ref": "#/parameters/DataApiVersionV2"
"$ref": "#/parameters/ApiVersion"
},
{
"$ref": "#/parameters/DataUploadOperationId"
Expand Down
12 changes: 6 additions & 6 deletions specification/maps/data-plane/Creator/preview/2.0/dataset.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
],
"responses": {},
"parameters": {
"DatasetApiVersionV2": {
"ApiVersion": {
"name": "api-version",
"description": "Version number of Azure Maps API.",
"type": "string",
Expand Down Expand Up @@ -117,7 +117,7 @@
"$ref": "../../../Common/preview/1.0/common.json#/parameters/ClientId"
},
{
"$ref": "#/parameters/DatasetApiVersionV2"
"$ref": "#/parameters/ApiVersion"
},
{
"$ref": "#/parameters/ConversionIdQuery"
Expand Down Expand Up @@ -154,7 +154,7 @@
"$ref": "../../../Common/preview/1.0/common.json#/parameters/ClientId"
},
{
"$ref": "#/parameters/DatasetApiVersionV2"
"$ref": "#/parameters/ApiVersion"
}
],
"x-ms-pageable": {
Expand Down Expand Up @@ -191,7 +191,7 @@
"$ref": "#/parameters/DatasetId"
},
{
"$ref": "#/parameters/DatasetApiVersionV2"
"$ref": "#/parameters/ApiVersion"
}
],
"responses": {
Expand Down Expand Up @@ -219,7 +219,7 @@
"$ref": "../../../Common/preview/1.0/common.json#/parameters/ClientId"
},
{
"$ref": "#/parameters/DatasetApiVersionV2"
"$ref": "#/parameters/ApiVersion"
},
{
"$ref": "#/parameters/DatasetId"
Expand Down Expand Up @@ -252,7 +252,7 @@
"$ref": "../../../Common/preview/1.0/common.json#/parameters/ClientId"
},
{
"$ref": "#/parameters/DatasetApiVersionV2"
"$ref": "#/parameters/ApiVersion"
},
{
"$ref": "#/parameters/DatasetOperationId"
Expand Down
Loading

0 comments on commit 0fe4385

Please sign in to comment.