[Rando] Prevent alarm when at full HP #4831
Merged
+10
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aMannus
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
This'll need to happen when we move this out of hook_handlers.cpp and it gets its own registration etc, but just noting it here: This'll need a check if rando is on and if the starting hearts are actually set to 1 heart.
For now it's fine because that whole switch case in hook_handlers.cpp is in a rando check iirc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To stop the low health beeping noise and Link's idle animation from playing when you only have 1 heart capacity. #4620
Build Artifacts