Fix: Handle nullptr for texture anim color change params #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Archez
force-pushed
the
tex-anim-color-change
branch
from
be05cdc to
e84b8a5
Compare
garrettjoecox
pushed a commit
that referenced
this pull request
May 22, 2024
* handle nullptr for texture anim color change params * bump otrexporter * oops
Eblo
added a commit
to Eblo/2ship2harkinian
that referenced
this pull request
Jan 13, 2025
* Fix Postman Hat check flags and branching * Use WEEKEVENTREG_90_04 instead for Postman's hat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some MM assets where the
envColorListorframeDataListare supposed to beNULL, but ZAPDTR/OTRExporter would set vectors for this. This led to issues where animated textures would set env colors from OOB (this can be observed by the animated texture in Wizrobe platforms being gray and disappearing every other frame).louist103/OTRExporter#16 updates the exporting to check for null addresses and set the lists size as 0 so that we can check that on the importer side to null out the lists.
Also brings in:
louist103/OTRExporter#14 - Fixes deku/zora/goron masks not rendering in the song of healing mask cutscenes
louist103/OTRExporter#15 - Fixes actors that fade in/out (like skull kid in intro cutscene, wizrobe platforms, big octoroks, aliens, etc) - Closes #137